2010-12-10 Joone Hur <joone@kldp.org>

        Reviewed by Xan Lopez.

        [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
        https://bugs.webkit.org/show_bug.cgi?id=50808

        Unskipping the following test cases:
        userscripts/mixed-case-stylesheet.html
        userscripts/simple-stylesheet.html
        userscripts/user-style-all-frames.html

        * platform/gtk/Skipped:
2010-12-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        Remove unnecessary variable names from DumpRenderTreeSupportGtk
        https://bugs.webkit.org/show_bug.cgi?id=50815

        There were some unnecessary variable names in DumpRenderTreeSupportGtk,
        so remove them.

        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
2010-12-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        webkit-patch: not possible to use build-and-test with local commits
        https://bugs.webkit.org/show_bug.cgi?id=33378

        Make --no-clean not even check if we have local commits.
        It's unclear to me why the code was originally written this way.
        I was unable to dig up a reason from svn history.

        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5ddfb643
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Xan Lopez.
[GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=50808
Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/simple-stylesheet.html
userscripts/user-style-all-frames.html
* platform/gtk/Skipped:
2010-12-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
......
......@@ -4701,7 +4701,16 @@ fast/events/ime-composition-events-001.html
fast/dom/tab-in-right-alignment.html
# No User Scripts
userscripts
userscripts/script-not-run-for-fragments.html
userscripts/script-run-at-end.html
userscripts/script-run-at-start.html
userscripts/user-script-all-frames.html
userscripts/user-script-audio-document.html
userscripts/user-script-image-document.html
userscripts/user-script-plugin-document.html
userscripts/user-script-top-frame-only.html
userscripts/user-script-video-document.html
userscripts/user-style-top-frame-only.html
# XHR sends sometimes yield null bytes sent instead of 0.
http/tests/xmlhttprequest/workers/shared-worker-methods.html
......
......@@ -10,6 +10,22 @@
* WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Xan Lopez.
[GTK] Unskipping some test cases in /userscripts dependent on addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=50808
Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/simple-stylesheet.html
userscripts/user-style-all-frames.html
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::addUserStyleSheet): Added "bool allFrames" parameter.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Eric Seidel.
......
......@@ -309,7 +309,7 @@ CString DumpRenderTreeSupportGtk::pageSizeAndMarginsInPixels(WebKitWebFrame* fra
* @sourceCode: code of a user stylesheet
*
*/
void DumpRenderTreeSupportGtk::addUserStyleSheet(WebKitWebFrame* frame, const char* sourceCode)
void DumpRenderTreeSupportGtk::addUserStyleSheet(WebKitWebFrame* frame, const char* sourceCode, bool allFrames)
{
g_return_if_fail(WEBKIT_IS_WEB_FRAME(frame));
......@@ -319,7 +319,7 @@ void DumpRenderTreeSupportGtk::addUserStyleSheet(WebKitWebFrame* frame, const ch
WebKitWebView* webView = getViewFromFrame(frame);
Page* page = core(webView);
page->group().addUserStyleSheetToWorld(mainThreadNormalWorld(), sourceCode, KURL(), 0, 0, WebCore::InjectInAllFrames);
page->group().addUserStyleSheetToWorld(mainThreadNormalWorld(), sourceCode, KURL(), 0, 0, allFrames ? InjectInAllFrames : InjectInTopFrameOnly);
}
/**
......
......@@ -53,7 +53,7 @@ public:
static WTF::CString pageProperty(WebKitWebFrame*, const char* propertyName, int pageNumber);
static bool isPageBoxVisible(WebKitWebFrame*, int pageNumber);
static WTF::CString pageSizeAndMarginsInPixels(WebKitWebFrame*, int pageNumber, int width, int height, int marginTop, int marginRight, int marginBottom, int marginLeft);
static void addUserStyleSheet(WebKitWebFrame*, const char* sourceCode);
static void addUserStyleSheet(WebKitWebFrame*, const char* sourceCode, bool allFrames);
static guint getPendingUnloadEventCount(WebKitWebFrame*);
static bool pauseAnimation(WebKitWebFrame*, const char* name, double time, const char* element);
static bool pauseTransition(WebKitWebFrame*, const char* name, double time, const char* element);
......
......@@ -41,6 +41,21 @@
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WebView::WebView):
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Xan Lopez.
[GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=50808
Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/simple-stylesheet.html
userscripts/user-style-all-frames.html
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::addUserStyleSheet):
2010-12-10 Joone Hur <joone@kldp.org>
Reviewed by Eric Seidel.
......
......@@ -716,7 +716,9 @@ void LayoutTestController::addUserScript(JSStringRef source, bool runAtStart, bo
void LayoutTestController::addUserStyleSheet(JSStringRef source, bool allFrames)
{
GOwnPtr<gchar> sourceCode(JSStringCopyUTF8CString(source));
DumpRenderTreeSupportGtk::addUserStyleSheet(mainFrame, sourceCode.get());
DumpRenderTreeSupportGtk::addUserStyleSheet(mainFrame, sourceCode.get(), allFrames);
// FIXME: needs more investigation why userscripts/user-style-top-frame-only.html fails when allFrames is false.
}
void LayoutTestController::setDeveloperExtrasEnabled(bool enabled)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment