Commit 1cf7bc93 authored by philn@webkit.org's avatar philn@webkit.org
Browse files

[GTK] ASSERT bug in WebAudio (AudioFileReader)

https://bugs.webkit.org/show_bug.cgi?id=81777

Reviewed by Martin Robinson.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
the GstBus floating reference.
(WebCore::AudioFileReader::createBus): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@111706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent be85c582
2012-03-22 Philippe Normand <pnormand@igalia.com>
[GTK] ASSERT bug in WebAudio (AudioFileReader)
https://bugs.webkit.org/show_bug.cgi?id=81777
Reviewed by Martin Robinson.
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::decodeAudioForBusCreation): Don't steal
the GstBus floating reference.
(WebCore::AudioFileReader::createBus): Ditto.
2012-03-22 Ilya Tikhonovsky <loislo@chromium.org>
 
Unreviewed: Web Inspector: fix syntax error in text.
......@@ -280,7 +280,7 @@ void AudioFileReader::decodeAudioForBusCreation()
// A deinterleave element is added once a src pad becomes available in decodebin.
m_pipeline = gst_pipeline_new(0);
GRefPtr<GstBus> bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
GRefPtr<GstBus> bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
gst_bus_add_signal_watch(bus.get());
g_signal_connect(bus.get(), "message", G_CALLBACK(messageCallback), this);
......@@ -334,7 +334,7 @@ PassOwnPtr<AudioBus> AudioFileReader::createBus(float sampleRate, bool mixToMono
g_main_loop_run(m_loop.get());
g_main_context_pop_thread_default(context.get());
GRefPtr<GstBus> bus = adoptGRef(gst_pipeline_get_bus(GST_PIPELINE(m_pipeline)));
GRefPtr<GstBus> bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
g_signal_handlers_disconnect_by_func(bus.get(), reinterpret_cast<gpointer>(messageCallback), this);
g_signal_handlers_disconnect_by_func(m_decodebin.get(), reinterpret_cast<gpointer>(onGStreamerDecodebinPadAddedCallback), this);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment