Commit 1ccbdc54 authored by akling@apple.com's avatar akling@apple.com

Devirtualize some things on Document.

From Blink r149967 by <esprehn@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149967>

Several methods on Document are virtual but don't override a super class method
and don't need to be virtual. This patch devirtualizes:

    - createElementNS()
    - finishedParsing()
    - suspendScriptedAnimationControllerCallbacks()
    - resumeScriptedAnimationControllerCallbacks()

It also removes the suspend and resume callbacks from ScriptExecutionContext
since they didn't need to be there.

* dom/Document.h:
* dom/ScriptExecutionContext.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 27332275
2013-05-12 Andreas Kling <akling@apple.com>
Devirtualize some things on Document.
From Blink r149967 by <esprehn@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149967>
Several methods on Document are virtual but don't override a super class method
and don't need to be virtual. This patch devirtualizes:
- createElementNS()
- finishedParsing()
- suspendScriptedAnimationControllerCallbacks()
- resumeScriptedAnimationControllerCallbacks()
It also removes the suspend and resume callbacks from ScriptExecutionContext
since they didn't need to be there.
* dom/Document.h:
* dom/ScriptExecutionContext.h:
2013-05-12 Andreas Kling <akling@apple.com>
Remove redundant call to removeAllEventListeners() in Document::open().
......
......@@ -358,7 +358,7 @@ public:
PassRefPtr<EntityReference> createEntityReference(const String& name, ExceptionCode&);
PassRefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, true, ec); }
PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionCode&);
virtual PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
PassRefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
bool cssStickyPositionEnabled() const;
......@@ -945,12 +945,12 @@ public:
virtual void postTask(PassOwnPtr<Task>); // Executes the task on context's thread asynchronously.
virtual void suspendScriptedAnimationControllerCallbacks();
virtual void resumeScriptedAnimationControllerCallbacks();
void suspendScriptedAnimationControllerCallbacks();
void resumeScriptedAnimationControllerCallbacks();
void windowScreenDidChange(PlatformDisplayID);
virtual void finishedParsing();
void finishedParsing();
bool inPageCache() const { return m_inPageCache; }
void setInPageCache(bool flag);
......
......@@ -111,9 +111,6 @@ public:
void didCreateDestructionObserver(ContextDestructionObserver*);
void willDestroyDestructionObserver(ContextDestructionObserver*);
virtual void suspendScriptedAnimationControllerCallbacks() { }
virtual void resumeScriptedAnimationControllerCallbacks() { }
// MessagePort is conceptually a kind of ActiveDOMObject, but it needs to be tracked separately for message dispatch.
void processMessagePortMessagesSoon();
void dispatchMessagePortEvents();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment