Commit 1a716e0f authored by antti@apple.com's avatar antti@apple.com

Simple line path does not respect visibility:hidden

https://bugs.webkit.org/show_bug.cgi?id=124467

Reviewed by Anders Carlsson.

Source/WebCore: 

Test: fast/text/text-visibility.html

* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):

LayoutTests: 

* fast/text/text-visibility-expected.html: Added.
* fast/text/text-visibility.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 9274172d
2013-11-17 Antti Koivisto <antti@apple.com>
Simple line path does not respect visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=124467
Reviewed by Anders Carlsson.
* fast/text/text-visibility-expected.html: Added.
* fast/text/text-visibility.html: Added.
2013-11-16 Alexey Proskuryakov <ap@apple.com>
WebCrypto no longer uses sequences of ArrayBuffers
......
<div>&nbsp;</div>
<div>visible</div>
<div>&nbsp;</div>
<div>visible</div>
<div>visible <span style="color:transparent">hidden </span>visible</div>
<div>visible visible visible</div>
<div>&nbsp;</div>
<div><span style="color:transparent">hidden </span>visible</div>
<div style="visibility:hidden">hidden</div>
<div style="visibility:visible">visible</div>
<div><span style="visibility:hidden">hidden</span></div>
<div><span style="visibility:visible">visible</span></div>
<div>visible <span style="visibility:hidden">hidden</span> visible</div>
<div>visible <span style="visibility:visible">visible</span> visible</div>
<div style="visibility:hidden">hidden <span style="visibility:hidden">hidden</span> hidden</div>
<div style="visibility:hidden">hidden <span style="visibility:visible">visible</span> hidden</div>
2013-11-17 Antti Koivisto <antti@apple.com>
Simple line path does not respect visibility:hidden
https://bugs.webkit.org/show_bug.cgi?id=124467
Reviewed by Anders Carlsson.
Test: fast/text/text-visibility.html
* rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
2013-11-16 Alexey Proskuryakov <ap@apple.com>
WebCrypto no longer uses sequences of ArrayBuffers
......
......@@ -63,16 +63,19 @@ void paintFlow(const RenderBlockFlow& flow, const Layout& layout, PaintInfo& pai
{
if (paintInfo.phase != PaintPhaseForeground)
return;
RenderStyle& style = flow.style();
if (style.visibility() != VISIBLE)
return;
RenderText& textRenderer = toRenderText(*flow.firstChild());
ASSERT(!textRenderer.firstTextBox());
bool debugBordersEnabled = flow.frame().settings().simpleLineLayoutDebugBordersEnabled();
RenderStyle& style = flow.style();
const Font& font = style.font();
GraphicsContext& context = *paintInfo.context;
const Font& font = style.font();
TextPaintStyle textPaintStyle = computeTextPaintStyle(textRenderer, style, paintInfo);
GraphicsContextStateSaver stateSaver(context, textPaintStyle.strokeWidth > 0);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment