Commit 1750e24a authored by darin@chromium.org's avatar darin@chromium.org

2008-12-08 Aaron Boodman <aa@chromium.org>

        Reviewed by Stephanie Lewis.

        https://bugs.webkit.org/show_bug.cgi?id=22301
        Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedParsing):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 0ed5434e
2008-12-08 Aaron Boodman <aa@chromium.org>
Reviewed by Stephanie Lewis.
https://bugs.webkit.org/show_bug.cgi?id=22301
Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
* fast/dom/Window/get-set-properties-expected.txt:
* fast/events/onunload-window-property-expected.txt:
* http/tests/loading/basic-expected.txt:
* http/tests/loading/empty-subframe-expected.txt:
* http/tests/loading/gmail-assert-on-load-expected.txt:
* http/tests/loading/location-hash-reload-cycle-expected.txt:
* http/tests/loading/onload-vs-immediate-refresh-expected.txt:
* http/tests/loading/slow-parsing-subframe-expected.txt:
* http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
* platform/mac/http/tests/loading/simple-subframe-expected.txt:
* webarchive/loading/test-loading-archive-expected.txt:
2008-12-08 Oliver Hunt <oliver@apple.com>
Reviewed by Alexey Proskuryakov.
......
main frame "window.marker.toString()" - has 1 onunload handler(s)
This page tests getting and setting window properties and functions.
......
main frame - has 1 onunload handler(s)
ALERT: unload
You should have seen an unload alert appear.
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
This is a test of load callbacks. It is only useful inside the regression test tool.
......@@ -2,11 +2,11 @@ main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
frame "f1" - didStartProvisionalLoadForFrame
frame "f1" - didCommitLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
frame "f1" - didFinishDocumentLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
frame "f1" - didFinishLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
This is a test of load callbacks. It is only useful inside the regression test tool.
......@@ -3,6 +3,7 @@ main frame - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
This test provokes HTMLTokenizer::timerFired to be called and from within timerFired we want to call WebCore::pageDestroyed.
......
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
This test checks that no loader actions occur when setting window.location.hash to the empty string or "#". If this test fails when run in a browser, it will reload continuously. If this test fails when run in DumpRenderTree, the FrameLoader callback output will contain willPerformClientRedirectToURL callbacks.
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
SUCCESS
......@@ -3,9 +3,9 @@ main frame - didCommitLoadForFrame
frame "f1" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
frame "f1" - didCommitLoadForFrame
frame "f1" - didFinishDocumentLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
frame "f1" - didFinishDocumentLoadForFrame
frame "f1" - didFinishLoadForFrame
main frame - didFinishLoadForFrame
This tests that we get frame load callbacks in the proper order when a subframe is parsed and created from within a timer callback.
......
frame "<!--framePath //<!--frame0-->-->" - has 1 onunload handler(s)
Test for bug 11450 REGRESSION: XMLHttpRequest::didFinishLoading() should immediately return if the request has already been aborted
If a frame has an active XMLHttpRequest that is still receiving data, and that frame is destroyed
......
......@@ -3,9 +3,9 @@ main frame - didCommitLoadForFrame
frame "f1" - didStartProvisionalLoadForFrame
main frame - didFinishDocumentLoadForFrame
frame "f1" - didCommitLoadForFrame
frame "f1" - didFinishDocumentLoadForFrame
frame "f1" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
frame "f1" - didFinishDocumentLoadForFrame
frame "f1" - didFinishLoadForFrame
main frame - didFinishLoadForFrame
layer at (0,0) size 800x600
......
......@@ -6,9 +6,9 @@ main frame - didFinishDocumentLoadForFrame
<unknown> - didFinishLoading
resources/helloworld.webarchive - didReceiveResponse <NSURLResponse resources/helloworld.webarchive>
frame "<!--framePath //<!--frame0-->-->" - didCommitLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didHandleOnloadEventsForFrame
main frame - didHandleOnloadEventsForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishDocumentLoadForFrame
frame "<!--framePath //<!--frame0-->-->" - didFinishLoadForFrame
main frame - didFinishLoadForFrame
This tests that doing a "normal load" of a webarchive (not using loadArchive) does not cause a cancelled error to be called.
2008-12-08 Aaron Boodman <aa@chromium.org>
Reviewed by Stephanie Lewis.
https://bugs.webkit.org/show_bug.cgi?id=22301
Make dispatchDidFinishLoading() always fire before didFinishLoadForFrame().
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
2008-12-08 Trenton Schulz <trenton.schulz@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
......@@ -1244,6 +1244,8 @@ void FrameLoader::finishedParsing()
// Null-checking the FrameView indicates whether or not we're in the destructor.
RefPtr<Frame> protector = m_frame->view() ? m_frame : 0;
m_client->dispatchDidFinishDocumentLoad();
checkCompleted();
if (!m_frame->view())
......@@ -1253,8 +1255,6 @@ void FrameLoader::finishedParsing()
// If not, remove them, relayout, and repaint.
m_frame->view()->restoreScrollbar();
m_client->dispatchDidFinishDocumentLoad();
gotoAnchor();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment