Commit 16476e78 authored by reni@webkit.org's avatar reni@webkit.org
Browse files

Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()

https://bugs.webkit.org/show_bug.cgi?id=120343

Reviewed by Darin Adler.

Source/WebCore:

Null-check the parent renderer of HTMLEmbedElement in WebCore::HTMLEmbedElement::rendererIsNeeded()
and early return.

Test: fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):

LayoutTests:

Test for the handling of null parent renderer.

* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt: Added.
* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 018efa13
2013-08-27 Renata Hodovan <reni@webkit.org>
Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120343
Reviewed by Darin Adler.
Test for the handling of null parent renderer.
* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash-expected.txt: Added.
* fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html: Added.
2013-08-27 Denis Nomiyama <d.nomiyama@samsung.com>
 
[GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
<html>
<div style="-webkit-flow-from:thread;">
<object>
<embed width="100">
</object>
</div>
<script>
if (window.testRunner)
testRunner.dumpAsText();
document.body.innerHTML = "PASS. WebKit didn't crash.";
</script>
</html>
2013-08-27 Renata Hodovan <reni@webkit.org>
Missing null-check of parent renderer in WebCore::HTMLEmbedElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120343
Reviewed by Darin Adler.
Null-check the parent renderer of HTMLEmbedElement in WebCore::HTMLEmbedElement::rendererIsNeeded()
and early return.
Test: fast/html/HTMLEmbedElement_without_parent_renderer_assert_crash.html
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
2013-08-27 Brent Fulgham <bfulgham@apple.com>
 
[Windows] Correct method call for characteristic update.
......@@ -186,7 +186,8 @@ bool HTMLEmbedElement::rendererIsNeeded(const RenderStyle& style)
// should be ignored and not get a renderer.
ContainerNode* p = parentNode();
if (p && p->hasTagName(objectTag)) {
ASSERT(p->renderer());
if (!p->renderer())
return false;
if (!static_cast<HTMLObjectElement*>(p)->useFallbackContent()) {
ASSERT(!p->renderer()->isEmbeddedObject());
return false;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment