Commit 14547540 authored by levin@chromium.org's avatar levin@chromium.org

[chromium] KURL::copy doesn't produce something usable on another thread.

https://bugs.webkit.org/show_bug.cgi?id=67809

Reviewed by Adam Barth.

No new functionality exposed so no new test. This was caught by testing code: the thread
sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708).

* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will
not be used on another thread.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 4e3a4b35
2011-09-08 David Levin <levin@chromium.org>
[chromium] KURL::copy doesn't produce something usable on another thread.
https://bugs.webkit.org/show_bug.cgi?id=67809
Reviewed by Adam Barth.
No new functionality exposed so no new test. This was caught by testing code: the thread
sanitizer run in Chromium (http://code.google.com/p/chromium/issues/detail?id=93708).
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::copyTo): Clear out the invalid String so that it will
not be used on another thread.
2011-09-08 Alexey Proskuryakov <ap@apple.com>
REGRESSION (r66874): Missing RefPtr in ScriptController
......@@ -284,6 +284,7 @@ void KURLGooglePrivate::copyTo(KURLGooglePrivate* dest) const
dest->m_utf8 = CString(m_utf8.data(), m_utf8.length());
dest->m_utf8IsASCII = m_utf8IsASCII;
dest->m_stringIsValid = false;
dest->m_string = String(); // Clear the invalid string to avoid cross thread ref counting.
}
String KURLGooglePrivate::componentString(const url_parse::Component& comp) const
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment