Commit 0db2e703 authored by apavlov@chromium.org's avatar apavlov@chromium.org

[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space

https://bugs.webkit.org/show_bug.cgi?id=87735

Reviewed by Kent Tamura.

This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.

No new tests, as popups are not testable in Chromium.

* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent fb1af932
2012-05-29 Alexander Pavlov <apavlov@chromium.org>
[Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space
https://bugs.webkit.org/show_bug.cgi?id=87735
Reviewed by Kent Tamura.
This change fixes the obsolete WebWidget Y-repositioning code for the insufficient vertical space case, not removed in r113418.
No new tests, as popups are not testable in Chromium.
* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
2012-05-29 Andrei Bucur <abucur@adobe.com>
[CSS Regions]Rename NamedFlow::overflow to NamedFlow::overset
......
......@@ -185,13 +185,10 @@ IntRect PopupContainer::layoutAndCalculateWidgetRect(int targetControlHeight, co
else
m_listBox->setMaxHeight(spaceBelow);
layoutAndGetRTLOffset();
// Our height has changed, so recompute only Y axis of widgetRect.
// We don't have to recompute X axis, so we only replace Y axis
// in widgetRect.
IntRect frameInScreen = chromeClient->rootViewToScreen(frameRect());
widgetRectInScreen.setY(frameInScreen.y());
widgetRectInScreen.setHeight(frameInScreen.height());
// And move upwards if necessary.
// Container height may have changed in layoutAndGetRTLOffset(),
// so set the WebWidget height to the container height.
widgetRectInScreen.setHeight(height());
// Move WebWidget upwards if necessary.
if (spaceAbove > spaceBelow)
widgetRectInScreen.move(0, -(widgetRectInScreen.height() + targetControlHeight));
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment