Commit 0cde5129 authored by vicki's avatar vicki
Browse files

Reviewed by Geoff.

        - fix <rdar://problem/4426668> REGRESSION: sometimes URLs with named anchors in a
        page don't jump to proper location in document (6916). Added test cases for this
        fix and past link jumping bug fixes.

        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::getUpperLeftCorner): Traverse up the parent node chain
        until you find one that has a sibling.
        * manual-tests/linkjump-1.html: Added a note here - the bug for this test case is
        still broken in TOT.
        * manual-tests/linkjump-2.html: Added. Renamed scrollToAnchor.html, to group it with the
        rest of the link jumping tests.
        * manual-tests/linkjump-3.html: Added. Test case for this bug, <rdar://problem/4426668>.
        * manual-tests/linkjump-4.html: Added. Test case for past fix, <rdar://problem/4247537>.
        * manual-tests/linkjump-5.html: Added. Test case for past fix, <rdar://problem/4256060>.
        * manual-tests/scrollToAnchor.html: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 11b709a7
2006-01-31 Vicki Murley <vicki@apple.com>
Reviewed by Geoff.
- fix <rdar://problem/4426668> REGRESSION: sometimes URLs with named anchors in a
page don't jump to proper location in document (6916). Added test cases for this
fix and past link jumping bug fixes.
* khtml/xml/ContainerNodeImpl.cpp:
(WebCore::ContainerNodeImpl::getUpperLeftCorner): Traverse up the parent node chain
until you find one that has a sibling.
* manual-tests/linkjump-1.html: Added a note here - the bug for this test case is
still broken in TOT.
* manual-tests/linkjump-2.html: Added. Renamed scrollToAnchor.html, to group it with the
rest of the link jumping tests.
* manual-tests/linkjump-3.html: Added. Test case for this bug, <rdar://problem/4426668>.
* manual-tests/linkjump-4.html: Added. Test case for past fix, <rdar://problem/4247537>.
* manual-tests/linkjump-5.html: Added. Test case for past fix, <rdar://problem/4256060>.
* manual-tests/scrollToAnchor.html: Removed.
2006-01-31 David Harrison <harrison@apple.com>
 
Reviewed by John.
......
......@@ -626,9 +626,13 @@ bool ContainerNodeImpl::getUpperLeftCorner(int &xPos, int &yPos) const
else if(o->nextSibling())
o = o->nextSibling();
else {
o = o->parent();
if (o)
o = o->nextSibling();
RenderObject *next = 0;
while (!next && o->parent()) {
o = o->parent();
next = o->nextSibling();
}
o = next;
if (!o)
break;
}
......
......@@ -5,6 +5,7 @@
</head>
<body>
<p><b>BUG ID:</b> <a href="rdar://problem/4304213">4304213</a> sometimes have to click twice to jump to top, on href=""</p>
<b>As of 01-31-2006, this bug has NOT been fixed.</b>
<p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b>
Click through the numbered links on this page.
......
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
<html lang="en">
<head>
</head>
<body>
<p><b>BUG ID:</b> <a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=6916">Bugzilla 6916</a> REGRESSION: URLs with named anchors in a page don't jump to proper location in document</p>
<p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b>
Manually resize window to about 800 x 600. Click the link below.</p>
<p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b>
Page will scroll down to the dashed line.
</p>
<p id="failure" style="background-color:#FF3300; padding:3px;"><b>TEST FAIL:</b>
Page will scroll to the bottom, or to some other unexpected area of the page.
</p>
<div>Clicking <a href="#link">link</a> should move page down to the dashes, not to the end of the page.</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<font face="arial,sans-serif" size="2"><a name="link"></a>
<div>--------------</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
<div>blah blah blah</div>
</body>
</html>
This diff is collapsed.
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">
<html lang="en">
<head>
</head>
<body>
<p><b>BUG ID:</b> <a href="rdar://problem/4256060">4256060</a> Link scrolling to last object on the page doesn't work if the link being scrolled to contains an empty inline</p>
<p id="test" style="background-color:skyblue; padding:3px;"><b>STEPS TO TEST:</b>
Manually resize window to about 800 x 600. Click the link below.
</p>
<p id="success" style="background-color:palegreen; padding:3px;"><b>TEST PASS:</b>
Page should scroll to the bottom.</p>
<p id="failure" style="background-color:#FF3300; padding:3px;"><b>TEST FAIL:</b>
Page will not scroll to the bottom.
</p>
<a href="#ccc">Click me</a>
<div style="border: 1px solid red; height: 800px"></div>
<a name="ccc"><b></b></a>
</body>
</html>
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment