Commit 08e598cd authored by tkent@chromium.org's avatar tkent@chromium.org

2010-08-24 Kent Tamura <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix 26 inspector test crashes
        https://bugs.webkit.org/show_bug.cgi?id=44580

        * platform/chromium/drt_expectations.txt:
2010-08-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Pavel Feldman.

        [DRT/Chromium] Fix 26 inspector test crashes
        https://bugs.webkit.org/show_bug.cgi?id=44580

        - DRTDevToolsAgent has a reference to the main WebView. So we
          should not clear it in closeDevTools() and should clear it in
          ~TestShell().
        - DRTDevToolsClient has a reference to a DevTools WebView and no
          way to update it. So we should delete DRTDevToolsClient instances
          in closeDevTools().

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::~TestShell):
        (TestShell::closeDevTools):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent fd267ebe
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix 26 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44580
* platform/chromium/drt_expectations.txt:
2010-08-24 Adam Barth <abarth@webkit.org>
Unskip XSSAuditor test and fix the source of flakiness. I'll make the
......@@ -208,17 +208,7 @@ BUG50197 WIN MAC LINUX : svg/dynamic-updates/SVGRadialGradientElement-svgdom-gra
// Need to implement something?
BUG_DRT WIN : http/tests/inspector-enabled/console-log-before-frame-navigation.html = CRASH
BUG_DRT WIN : http/tests/inspector/console-resource-errors.html = CRASH
BUG_DRT WIN : http/tests/inspector/inspect-iframe-from-different-domain.html = CRASH
BUG_DRT WIN : http/tests/inspector/resource-parameters.html = CRASH
BUG_DRT WIN : inspector/console-assert.html = CRASH
BUG_DRT WIN : inspector/console-command-clear.html = CRASH
BUG_DRT WIN : inspector/console-dir.html = CRASH
BUG_DRT WIN : inspector/console-eval-global.html = CRASH
BUG_DRT WIN : inspector/console-format-collections.html = CRASH
BUG_DRT WIN : inspector/console-log-before-inspector-open.html = CRASH
BUG_DRT WIN : inspector/console-tests.html = CRASH
BUG_DRT WIN : inspector/cookie-resource-match.html = CRASH
BUG_DRT WIN : http/tests/inspector/resource-parameters.html = TEXT CRASH PASS
BUG_DRT WIN : inspector/debugger-eval-while-paused.html = CRASH
BUG_DRT WIN : inspector/debugger-no-nested-pause.html = CRASH
BUG_DRT WIN : inspector/debugger-pause-in-eval-script.html = CRASH
......@@ -228,22 +218,6 @@ BUG_DRT WIN : inspector/debugger-step-in.html = CRASH
BUG_DRT WIN : inspector/debugger-step-out.html = CRASH
BUG_DRT WIN : inspector/debugger-step-over.html = CRASH
BUG_DRT WIN : inspector/dom-breakpoints.html = CRASH
BUG_DRT WIN : inspector/elements-panel-limited-children.html = CRASH
BUG_DRT WIN : inspector/elements-panel-search.html = CRASH
BUG_DRT WIN : inspector/elements-panel-structure.html = CRASH
BUG_DRT WIN : inspector/elements-panel-xhtml-structure.xhtml = CRASH
BUG_DRT WIN : inspector/inspected-objects-not-overriden.html = CRASH
BUG_DRT WIN : inspector/styles-disable-inherited.html = CRASH
BUG_DRT WIN : inspector/styles-disable-then-enable.html = CRASH
BUG_DRT WIN : inspector/styles-source-lines-inline.html = CRASH
BUG_DRT WIN : inspector/styles-source-offsets.html = CRASH
BUG_DRT WIN : inspector/syntax-highlight-html.html = CRASH
BUG_DRT WIN : inspector/timeline-enum-stability.html = CRASH
BUG_DRT WIN : inspector/timeline-layout.html = CRASH
BUG_DRT WIN : inspector/timeline-network-resource.html = CRASH
BUG_DRT WIN : inspector/timeline-parse-html.html = CRASH
BUG_DRT WIN : inspector/timeline-script-tag-1.html = CRASH
BUG_DRT WIN : inspector/timeline-trivial.html = CRASH
// WebGL tests sometimes fail only on the buildbot.
......
2010-08-24 Kent Tamura <tkent@chromium.org>
Reviewed by Pavel Feldman.
[DRT/Chromium] Fix 26 inspector test crashes
https://bugs.webkit.org/show_bug.cgi?id=44580
- DRTDevToolsAgent has a reference to the main WebView. So we
should not clear it in closeDevTools() and should clear it in
~TestShell().
- DRTDevToolsClient has a reference to a DevTools WebView and no
way to update it. So we should delete DRTDevToolsClient instances
in closeDevTools().
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):
(TestShell::closeDevTools):
2010-08-24 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
......
......@@ -118,6 +118,7 @@ TestShell::~TestShell()
callJSGC();
// Destroy the WebView before its WebViewHost.
m_drtDevToolsAgent->setWebView(0);
m_webView->close();
}
......@@ -145,9 +146,7 @@ void TestShell::closeDevTools()
{
if (m_devTools) {
m_drtDevToolsAgent->reset();
if (m_drtDevToolsClient)
m_drtDevToolsClient->reset();
m_drtDevToolsAgent->setWebView(0);
m_drtDevToolsClient.clear();
closeWindow(m_devTools);
m_devTools = 0;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment