Commit 08ca6f3a authored by aroben's avatar aroben

Remove ContextMenuClient::shouldIncludeInspectElementItem

WebCore:

        Remove ContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        No regression test possible.

        * page/ContextMenuClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Use Settings
        to determine whether to include the Inspect Element item.
        * page/gdk/ContextMenuClientGdk.cpp:
        * page/gdk/ContextMenuClientGdk.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:

WebKit:

        Remove WebContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:

WebKit/win:

        Remove WebContextMenuClient::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebContextMenuClient.cpp:
        * WebContextMenuClient.h:

WebKitQt:

        Remove ContextMenuClientQt::shouldIncludeInspectElementItem

        Reviewed by Tim.

        * WebCoreSupport/ContextMenuClientQt.cpp:
        * WebCoreSupport/ContextMenuClientQt.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 2c74a80b
2007-07-17 Adam Roben <aroben@apple.com>
Remove ContextMenuClient::shouldIncludeInspectElementItem
Reviewed by Tim.
No regression test possible.
* page/ContextMenuClient.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::handleContextMenuEvent): Use Settings
to determine whether to include the Inspect Element item.
* page/gdk/ContextMenuClientGdk.cpp:
* page/gdk/ContextMenuClientGdk.h:
* platform/graphics/svg/SVGImageEmptyClients.h:
2007-07-17 Adam Roben <aroben@apple.com>
Initialize ContextMenuController::m_page
......@@ -49,7 +49,6 @@ namespace WebCore {
virtual void lookUpInDictionary(Frame*) = 0;
virtual void speak(const String&) = 0;
virtual void stopSpeaking() = 0;
virtual bool shouldIncludeInspectElementItem() = 0;
#if PLATFORM(MAC)
virtual void searchWithSpotlight() = 0;
......
......@@ -52,6 +52,7 @@
#include "ReplaceSelectionCommand.h"
#include "ResourceRequest.h"
#include "SelectionController.h"
#include "Settings.h"
#include "markup.h"
namespace WebCore {
......@@ -97,9 +98,7 @@ void ContextMenuController::handleContextMenuEvent(Event* event)
PlatformMenuDescription customMenu = m_client->getCustomMenuFromDefaultItems(m_contextMenu.get());
m_contextMenu->setPlatformDescription(customMenu);
// FIXME: We should be asking Settings whether to include the Inspect
// Element item, rather than our client.
if (m_client->shouldIncludeInspectElementItem())
if (m_page->settings()->developerExtrasEnabled())
m_contextMenu->addInspectElementItem();
event->setDefaultHandled();
}
......
......@@ -80,11 +80,5 @@ void ContextMenuClientGdk::stopSpeaking()
notImplemented();
}
bool ContextMenuClientGdk::shouldIncludeInspectElementItem()
{
notImplemented();
return false;
}
}
......@@ -45,7 +45,6 @@ namespace WebCore {
virtual void lookUpInDictionary(Frame*);
virtual void speak(const String&);
virtual void stopSpeaking();
virtual bool shouldIncludeInspectElementItem();
};
}
......
......@@ -374,7 +374,6 @@ public:
virtual void lookUpInDictionary(Frame*) { }
virtual void speak(const String&) { }
virtual void stopSpeaking() { }
virtual bool shouldIncludeInspectElementItem() { return false; }
#if PLATFORM(MAC)
virtual void searchWithSpotlight() { }
......
2007-07-17 Adam Roben <aroben@apple.com>
Remove WebContextMenuClient::shouldIncludeInspectElementItem
Reviewed by Tim.
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebContextMenuClient.mm:
2007-07-17 Adam Roben <aroben@apple.com>
Initialize Settings::developerExtrasEnabled
......
......@@ -47,7 +47,6 @@ public:
virtual void speak(const WebCore::String&);
virtual void stopSpeaking();
virtual void searchWithSpotlight();
virtual bool shouldIncludeInspectElementItem();
WebView *webView() { return m_webView; }
......
......@@ -288,8 +288,3 @@ void WebContextMenuClient::stopSpeaking()
{
[NSApp stopSpeaking];
}
bool WebContextMenuClient::shouldIncludeInspectElementItem()
{
return [WebView _developerExtrasEnabled];
}
2007-07-17 Adam Roben <aroben@apple.com>
Remove WebContextMenuClient::shouldIncludeInspectElementItem
Reviewed by Tim.
* WebContextMenuClient.cpp:
* WebContextMenuClient.h:
2007-07-17 Adam Roben <aroben@apple.com>
Initialize Settings::developerExtrasEnabled
......
......@@ -135,9 +135,3 @@ void WebContextMenuClient::stopSpeaking()
{
notImplemented();
}
bool WebContextMenuClient::shouldIncludeInspectElementItem()
{
notImplemented();
return true;
}
......@@ -45,7 +45,6 @@ public:
virtual void lookUpInDictionary(WebCore::Frame*);
virtual void speak(const WebCore::String&);
virtual void stopSpeaking();
virtual bool shouldIncludeInspectElementItem();
private:
WebView* m_webView;
......
2007-07-17 Adam Roben <aroben@apple.com>
Remove ContextMenuClientQt::shouldIncludeInspectElementItem
Reviewed by Tim.
* WebCoreSupport/ContextMenuClientQt.cpp:
* WebCoreSupport/ContextMenuClientQt.h:
2007-07-16 Adam Roben <aroben@apple.com>
Updated ChromeClientQt for ChromeClient changes.
......
......@@ -76,11 +76,5 @@ void ContextMenuClientQt::searchWithGoogle(const Frame*)
notImplemented();
}
bool ContextMenuClientQt::shouldIncludeInspectElementItem()
{
notImplemented();
return false;
}
}
......@@ -46,8 +46,6 @@ namespace WebCore {
virtual void speak(const String&);
virtual void stopSpeaking();
virtual void searchWithGoogle(const Frame*);
virtual bool shouldIncludeInspectElementItem();
};
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment