Commit 083d46a1 authored by caseq@chromium.org's avatar caseq@chromium.org

Web Inspector: Fix checkbox position on Settings screen.

https://bugs.webkit.org/show_bug.cgi?id=87007

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.

Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

UI changes, no new tests.

* inspector/front-end/helpScreen.css:
(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5f3e2fa7
2012-05-31 Eugene Klyuchnikov <eustas.bug@gmail.com>
Web Inspector: Fix checkbox position on Settings screen.
https://bugs.webkit.org/show_bug.cgi?id=87007
Reviewed by Yury Semikhatsky.
Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.
UI changes, no new tests.
* inspector/front-end/helpScreen.css:
(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.
2012-05-30 Andreas Kling <kling@webkit.org>
Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>
Reviewed by Antti Koivisto.
Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.
Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):
2012-05-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
......
......@@ -109,15 +109,23 @@ body:not(.platform-mac) .help-close-button {
.help-container {
width: 100%;
-webkit-user-select: auto;
-webkit-column-width: 480px;
-webkit-column-width: 470px;
}
body.platform-mac .help-container {
-webkit-column-width: 330px;
}
.help-block {
display: inline-block;
width: 480px;
width: 470px;
padding-bottom: 9px;
}
body.platform-mac .help-block {
width: 330px;
}
#settings.help-container {
-webkit-column-width: 240px;
}
......@@ -132,10 +140,14 @@ body:not(.platform-mac) .help-close-button {
.help-key-cell {
display: inline-block;
width: 280px;
width: 270px;
text-align: right;
}
body.platform-mac .help-key-cell {
width: 120px;
}
.help-cell {
display: inline;
}
......@@ -168,7 +180,7 @@ body.platform-mac .help-key {
}
.help-content p {
margin: 0 0 3px 0;
margin: 3px 0;
}
.help-content fieldset {
......@@ -182,7 +194,6 @@ body.platform-mac .help-key {
padding-left: 3px;
}
.help-content fieldset label {
padding-right: 4px;
}
......@@ -206,8 +217,20 @@ body.platform-mac .help-key {
.help-content input[type=checkbox] {
height: 13px;
width: 13px;
margin-left: 0;
margin-right: 4px;
margin: 0 4px 0 0;
vertical-align: -2px;
}
body.platform-mac .help-content input[type=checkbox] {
vertical-align: -1px;
}
.help-content input[type=radio] {
vertical-align: -2px;
}
body.platform-mac .help-content input[type=radio] {
vertical-align: -1px;
}
.help-content select {
......@@ -252,7 +275,8 @@ body:not(.compact) #settings-screen .tabbed-pane {
}
#settings-screen .help-close-button {
margin: 6px 0;
margin-top: 6px;
margin-bottom: 6px;
}
#settings-screen .tabbed-pane-header-tab.selected {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment