Commit 078b8c80 authored by commit-queue@webkit.org's avatar commit-queue@webkit.org
Browse files

remove parentsOnly variable in codeGenerator.pm

https://bugs.webkit.org/show_bug.cgi?id=113457

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

Remove unused variable parentsOnly.

No new tests: no change in behaviour.

* bindings/scripts/CodeGenerator.pm:
(ForAllParents):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(ParseInterface):
(InheritsInterface):
(InheritsExtendedAttribute):
* bindings/scripts/CodeGeneratorV8.pm:
(BaseInterfaceName):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 22bedfa6
2013-03-27 Arnaud Renevier <a.renevier@sisa.samsung.com>
remove parentsOnly variable in codeGenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=113457
Reviewed by Kentaro Hara.
Remove unused variable parentsOnly.
No new tests: no change in behaviour.
* bindings/scripts/CodeGenerator.pm:
(ForAllParents):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(ParseInterface):
(InheritsInterface):
(InheritsExtendedAttribute):
* bindings/scripts/CodeGeneratorV8.pm:
(BaseInterfaceName):
2013-03-27 Beth Dakin <bdakin@apple.com> 2013-03-27 Beth Dakin <bdakin@apple.com>
   
Need WK2 API to give a WebView a header and footer Need WK2 API to give a WebView a header and footer
...@@ -175,7 +175,6 @@ sub ForAllParents ...@@ -175,7 +175,6 @@ sub ForAllParents
my $interface = shift; my $interface = shift;
my $beforeRecursion = shift; my $beforeRecursion = shift;
my $afterRecursion = shift; my $afterRecursion = shift;
my $parentsOnly = shift;
my $recurse; my $recurse;
$recurse = sub { $recurse = sub {
...@@ -183,7 +182,7 @@ sub ForAllParents ...@@ -183,7 +182,7 @@ sub ForAllParents
for (@{$currentInterface->parents}) { for (@{$currentInterface->parents}) {
my $interfaceName = $_; my $interfaceName = $_;
my $parentInterface = $object->ParseInterface($interfaceName, $parentsOnly); my $parentInterface = $object->ParseInterface($interfaceName);
if ($beforeRecursion) { if ($beforeRecursion) {
&$beforeRecursion($parentInterface) eq 'prune' and next; &$beforeRecursion($parentInterface) eq 'prune' and next;
...@@ -226,7 +225,7 @@ sub AddMethodsConstantsAndAttributesFromParentInterfaces ...@@ -226,7 +225,7 @@ sub AddMethodsConstantsAndAttributesFromParentInterfaces
$object->ForAllParents($currentInterface, sub { $object->ForAllParents($currentInterface, sub {
my $currentInterface = shift; my $currentInterface = shift;
push(@$parents, $currentInterface->name); push(@$parents, $currentInterface->name);
}, undef, 1); }, undef);
} }
# Prune the recursion here. # Prune the recursion here.
...@@ -290,7 +289,6 @@ sub ParseInterface ...@@ -290,7 +289,6 @@ sub ParseInterface
{ {
my $object = shift; my $object = shift;
my $interfaceName = shift; my $interfaceName = shift;
my $parentsOnly = shift;
return undef if $interfaceName eq 'Object'; return undef if $interfaceName eq 'Object';
...@@ -306,7 +304,7 @@ sub ParseInterface ...@@ -306,7 +304,7 @@ sub ParseInterface
# Step #2: Parse the found IDL file (in quiet mode). # Step #2: Parse the found IDL file (in quiet mode).
my $parser = IDLParser->new(1); my $parser = IDLParser->new(1);
my $document = $parser->Parse($filename, $defines, $preprocessor, $parentsOnly); my $document = $parser->Parse($filename, $defines, $preprocessor);
foreach my $interface (@{$document->interfaces}) { foreach my $interface (@{$document->interfaces}) {
if ($interface->name eq $interfaceName) { if ($interface->name eq $interfaceName) {
...@@ -777,7 +775,7 @@ sub InheritsInterface ...@@ -777,7 +775,7 @@ sub InheritsInterface
$found = 1; $found = 1;
} }
return 1 if $found; return 1 if $found;
}, 0, 1); }, 0);
return $found; return $found;
} }
...@@ -796,7 +794,7 @@ sub InheritsExtendedAttribute ...@@ -796,7 +794,7 @@ sub InheritsExtendedAttribute
$found = 1; $found = 1;
} }
return 1 if $found; return 1 if $found;
}, 0, 1); }, 0);
return $found; return $found;
} }
......
...@@ -3680,7 +3680,7 @@ sub BaseInterfaceName ...@@ -3680,7 +3680,7 @@ sub BaseInterfaceName
my $interface = shift; my $interface = shift;
while (@{$interface->parents}) { while (@{$interface->parents}) {
$interface = $codeGenerator->ParseInterface(@{$interface->parents}[0], 1); $interface = $codeGenerator->ParseInterface(@{$interface->parents}[0]);
} }
return $interface->name; return $interface->name;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment