Commit 063e3b65 authored by timothy@apple.com's avatar timothy@apple.com
Browse files

Remove #ifndef BUILDING_ON_TIGER around code that schedules runloop modes

        for Page, so the new RunLoopTimer in WebCore always gets a default mode.
        Fixes the layout test failures on the Tiger build bots.

        Reviewed by Mark Rowe.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView scheduleInRunLoop:forMode:]):
        (-[WebView unscheduleFromRunLoop:forMode:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent ea7de387
2009-03-19 Timothy Hatcher <timothy@apple.com>
Remove #ifndef BUILDING_ON_TIGER around code that schedules runloop modes
for Page, so the new RunLoopTimer in WebCore always gets a default mode.
Fixes the layout test failures on the Tiger build bots.
Reviewed by Mark Rowe.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
(-[WebView scheduleInRunLoop:forMode:]):
(-[WebView unscheduleFromRunLoop:forMode:]):
2009-03-18 Anders Carlsson <andersca@apple.com> 2009-03-18 Anders Carlsson <andersca@apple.com>
   
Reviewed by Oliver Hunt. Reviewed by Oliver Hunt.
......
...@@ -737,12 +737,10 @@ static void WebKitInitializeApplicationCachePathIfNecessary() ...@@ -737,12 +737,10 @@ static void WebKitInitializeApplicationCachePathIfNecessary()
[WebFrame _createMainFrameWithPage:_private->page frameName:frameName frameView:frameView]; [WebFrame _createMainFrameWithPage:_private->page frameName:frameName frameView:frameView];
#ifndef BUILDING_ON_TIGER
if (WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES)) if (WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES))
[self scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes]; [self scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSRunLoopCommonModes];
else else
[self scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSDefaultRunLoopMode]; [self scheduleInRunLoop:[NSRunLoop mainRunLoop] forMode:NSDefaultRunLoopMode];
#endif
[self _addToAllWebViewsSet]; [self _addToAllWebViewsSet];
[self setGroupName:groupName]; [self setGroupName:groupName];
...@@ -3630,18 +3628,14 @@ static WebFrame *incrementFrame(WebFrame *curr, BOOL forward, BOOL wrapFlag) ...@@ -3630,18 +3628,14 @@ static WebFrame *incrementFrame(WebFrame *curr, BOOL forward, BOOL wrapFlag)
- (void)scheduleInRunLoop:(NSRunLoop *)runLoop forMode:(NSString *)mode - (void)scheduleInRunLoop:(NSRunLoop *)runLoop forMode:(NSString *)mode
{ {
#ifndef BUILDING_ON_TIGER
if (runLoop && mode) if (runLoop && mode)
core(self)->addSchedulePair(SchedulePair::create(runLoop, (CFStringRef)mode)); core(self)->addSchedulePair(SchedulePair::create(runLoop, (CFStringRef)mode));
#endif
} }
- (void)unscheduleFromRunLoop:(NSRunLoop *)runLoop forMode:(NSString *)mode - (void)unscheduleFromRunLoop:(NSRunLoop *)runLoop forMode:(NSString *)mode
{ {
#ifndef BUILDING_ON_TIGER
if (runLoop && mode) if (runLoop && mode)
core(self)->removeSchedulePair(SchedulePair::create(runLoop, (CFStringRef)mode)); core(self)->removeSchedulePair(SchedulePair::create(runLoop, (CFStringRef)mode));
#endif
} }
- (BOOL)searchFor:(NSString *)string direction:(BOOL)forward caseSensitive:(BOOL)caseFlag wrap:(BOOL)wrapFlag startInSelection:(BOOL)startInSelection - (BOOL)searchFor:(NSString *)string direction:(BOOL)forward caseSensitive:(BOOL)caseFlag wrap:(BOOL)wrapFlag startInSelection:(BOOL)startInSelection
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment