Commit 05fdb04b authored by ap@apple.com's avatar ap@apple.com

Reviewed by Joseph Pecoraro.

        Hide appcache status bar items
        https://bugs.webkit.org/show_bug.cgi?id=60799

        We have a number of non-trivial bugs that make these more misleading than helpful to developers.

        * inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
        Just hide the items for now. Removing all support code would be complicated, and not helpful.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 7bea0541
2011-05-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Joseph Pecoraro.
Hide appcache status bar items
https://bugs.webkit.org/show_bug.cgi?id=60799
We have a number of non-trivial bugs that make these more misleading than helpful to developers.
* inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView):
Just hide the items for now. Removing all support code would be complicated, and not helpful.
2011-05-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
......@@ -30,13 +30,11 @@ WebInspector.ApplicationCacheItemsView = function(treeElement, appcacheDomain)
this.element.addStyleClass("storage-view");
this.element.addStyleClass("table");
// FIXME: Delete Button semantics are not yet defined.
// FIXME: Needs better tooltip. (Localized)
this.deleteButton = new WebInspector.StatusBarButton(WebInspector.UIString("Delete"), "delete-storage-status-bar-item");
this.deleteButton.visible = false;
this.deleteButton.addEventListener("click", this._deleteButtonClicked.bind(this), false);
// FIXME: Refresh Button semantics are not yet defined.
// FIXME: Needs better tooltip. (Localized)
this.refreshButton = new WebInspector.StatusBarButton(WebInspector.UIString("Refresh"), "refresh-storage-status-bar-item");
this.refreshButton.addEventListener("click", this._refreshButtonClicked.bind(this), false);
......@@ -69,6 +67,21 @@ WebInspector.ApplicationCacheItemsView = function(treeElement, appcacheDomain)
this.element.appendChild(this._emptyMsgElement);
this.updateStatus(applicationCache.UNCACHED);
// FIXME: Status bar items don't work well enough yet, so they are being hidden.
// http://webkit.org/b/41637 Web Inspector: Give Semantics to "Refresh" and "Delete" Buttons in ApplicationCache DataGrid
// http://webkit.org/b/60590 Application cache status always displayed as UNCACHED at first
// http://webkit.org/b/60793 Application cache status indicator gets stuck at DOWNLOADING after a failure
this.deleteButton.element.style.display = "none";
this.refreshButton.element.style.display = "none";
if (Preferences.onlineDetectionEnabled) {
this.connectivityIcon.style.display = "none";
this.connectivityMessage.style.display = "none";
}
this.divider.style.display = "none";
this.statusIcon.style.display = "none";
this.statusMessage.style.display = "none";
}
WebInspector.ApplicationCacheItemsView.prototype = {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment