Commit 0094033c authored by eric@webkit.org's avatar eric@webkit.org
Browse files

2010-04-27 Jay Civelli <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Merged the WebView public method to close suggestion popups
        into a single method to close all popups (select and suggestions).
        That ensures select popups are closed when the browser window is moved
        or resized.
        https://bugs.webkit.org/show_bug.cgi?id=37837

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::hidePopups):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        * src/WebViewImpl.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent fb6885b2
2010-04-27 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
[chromium] Merged the WebView public method to close suggestion popups
into a single method to close all popups (select and suggestions).
That ensures select popups are closed when the browser window is moved
or resized.
https://bugs.webkit.org/show_bug.cgi?id=37837
* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hidePopups):
(WebKit::WebViewImpl::hideSuggestionsPopup):
* src/WebViewImpl.h:
2010-04-27 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Adler.
......
......@@ -246,10 +246,12 @@ public:
const WebVector<WebString>& suggestions,
int defaultSuggestionIndex) = 0;
// DEPRECATED: WebView::hideSuggestionsPopup is the new way to access this.
virtual void hideAutofillPopup() = 0;
// Hides any popup (suggestions, selects...) that might be showing.
virtual void hidePopups() = 0;
// Hides the suggestions popup if any are showing.
// DEPRECATED: use hidePopups() instead.
virtual void hideAutofillPopup() = 0;
virtual void hideSuggestionsPopup() = 0;
......
......@@ -1789,6 +1789,12 @@ void WebViewImpl::applyAutocompleteSuggestions(
}
}
void WebViewImpl::hidePopups()
{
hideSelectPopup();
hideSuggestionsPopup();
}
void WebViewImpl::hideAutofillPopup()
{
hideSuggestionsPopup();
......
......@@ -169,6 +169,7 @@ public:
const WebNode&,
const WebVector<WebString>& suggestions,
int defaultSuggestionIndex);
virtual void hidePopups();
virtual void hideAutofillPopup();
virtual void hideSuggestionsPopup();
virtual void setScrollbarColors(unsigned inactiveColor,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment