Skip to content
  • mark.lam@apple.com's avatar
    Change the Supplementable class to not use AtomicString. · e69ee170
    mark.lam@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=107535.
    
    Reviewed by Adam Barth.
    
    Replaced the use of AtomicString keys with literal const char* keys.
    This simplifies the SupplementMap and makes it slightly leaner and faster.
    
    Source/WebCore: 
    
    No new tests.
    
    * Modules/battery/BatteryController.cpp:
    (WebCore::BatteryController::supplementName):
    * Modules/battery/BatteryController.h:
    (BatteryController):
    * Modules/battery/NavigatorBattery.cpp:
    (WebCore::NavigatorBattery::supplementName):
    (WebCore):
    (WebCore::NavigatorBattery::from):
    * Modules/battery/NavigatorBattery.h:
    (NavigatorBattery):
    * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
    (WebCore::DraggedIsolatedFileSystem::supplementName):
    * Modules/filesystem/chromium/DraggedIsolatedFileSystem.h:
    (DraggedIsolatedFileSystem):
    * Modules/gamepad/NavigatorGamepad.cpp:
    (WebCore::NavigatorGamepad::supplementName):
    (WebCore):
    (WebCore::NavigatorGamepad::from):
    * Modules/gamepad/NavigatorGamepad.h:
    (NavigatorGamepad):
    * Modules/geolocation/GeolocationController.cpp:
    (WebCore::GeolocationController::supplementName):
    * Modules/geolocation/GeolocationController.h:
    (GeolocationController):
    * Modules/geolocation/NavigatorGeolocation.cpp:
    (WebCore::NavigatorGeolocation::supplementName):
    (WebCore):
    (WebCore::NavigatorGeolocation::from):
    * Modules/geolocation/NavigatorGeolocation.h:
    (NavigatorGeolocation):
    * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
    (WebCore::DOMWindowIndexedDatabase::supplementName):
    (WebCore):
    (WebCore::DOMWindowIndexedDatabase::from):
    * Modules/indexeddb/DOMWindowIndexedDatabase.h:
    (DOMWindowIndexedDatabase):
    * Modules/indexeddb/PageGroupIndexedDatabase.cpp:
    (WebCore::PageGroupIndexedDatabase::supplementName):
    (WebCore):
    (WebCore::PageGroupIndexedDatabase::from):
    * Modules/indexeddb/PageGroupIndexedDatabase.h:
    (PageGroupIndexedDatabase):
    * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
    (WebCore::WorkerContextIndexedDatabase::supplementName):
    (WebCore):
    (WebCore::WorkerContextIndexedDatabase::from):
    * Modules/indexeddb/WorkerContextIndexedDatabase.h:
    (WorkerContextIndexedDatabase):
    * Modules/intents/DOMWindowIntents.cpp:
    (WebCore::DOMWindowIntents::supplementName):
    (WebCore):
    (WebCore::DOMWindowIntents::from):
    * Modules/intents/DOMWindowIntents.h:
    (DOMWindowIntents):
    * Modules/mediastream/UserMediaController.cpp:
    (WebCore::UserMediaController::supplementName):
    * Modules/mediastream/UserMediaController.h:
    (UserMediaController):
    * Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
    (WebCore::NavigatorContentUtils::supplementName):
    * Modules/navigatorcontentutils/NavigatorContentUtils.h:
    (NavigatorContentUtils):
    * Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:
    (WebCore::NavigatorNetworkInfoConnection::supplementName):
    (WebCore):
    (WebCore::NavigatorNetworkInfoConnection::from):
    * Modules/networkinfo/NavigatorNetworkInfoConnection.h:
    (NavigatorNetworkInfoConnection):
    * Modules/networkinfo/NetworkInfoController.cpp:
    (WebCore::NetworkInfoController::supplementName):
    * Modules/networkinfo/NetworkInfoController.h:
    (NetworkInfoController):
    * Modules/notifications/DOMWindowNotifications.cpp:
    (WebCore::DOMWindowNotifications::supplementName):
    (WebCore):
    (WebCore::DOMWindowNotifications::from):
    * Modules/notifications/DOMWindowNotifications.h:
    (DOMWindowNotifications):
    * Modules/notifications/NotificationController.cpp:
    (WebCore::NotificationController::supplementName):
    * Modules/notifications/NotificationController.h:
    (NotificationController):
    * Modules/notifications/WorkerContextNotifications.cpp:
    (WebCore::WorkerContextNotifications::supplementName):
    (WebCore):
    (WebCore::WorkerContextNotifications::from):
    * Modules/notifications/WorkerContextNotifications.h:
    (WorkerContextNotifications):
    * Modules/quota/DOMWindowQuota.cpp:
    (WebCore::DOMWindowQuota::supplementName):
    (WebCore):
    (WebCore::DOMWindowQuota::from):
    * Modules/quota/DOMWindowQuota.h:
    (DOMWindowQuota):
    * Modules/speech/DOMWindowSpeechSynthesis.cpp:
    (WebCore::DOMWindowSpeechSynthesis::supplementName):
    (WebCore):
    (WebCore::DOMWindowSpeechSynthesis::from):
    * Modules/speech/DOMWindowSpeechSynthesis.h:
    (DOMWindowSpeechSynthesis):
    * Modules/speech/SpeechRecognitionController.cpp:
    (WebCore::SpeechRecognitionController::supplementName):
    * Modules/speech/SpeechRecognitionController.h:
    (SpeechRecognitionController):
    * Modules/vibration/Vibration.cpp:
    (WebCore::Vibration::supplementName):
    * Modules/vibration/Vibration.h:
    (Vibration):
    * Modules/webdatabase/DatabaseContext.cpp:
    (WebCore::DatabaseContext::supplementName):
    (WebCore):
    (WebCore::DatabaseContext::existingDatabaseContextFrom):
    (WebCore::DatabaseContext::from):
    * Modules/webdatabase/DatabaseContext.h:
    (DatabaseContext):
    * dom/ContextFeatures.cpp:
    (WebCore::ContextFeatures::supplementName):
    * dom/ContextFeatures.h:
    * dom/DeviceMotionController.cpp:
    (WebCore::DeviceMotionController::supplementName):
    * dom/DeviceMotionController.h:
    (DeviceMotionController):
    * dom/DeviceOrientationController.cpp:
    (WebCore::DeviceOrientationController::supplementName):
    * dom/DeviceOrientationController.h:
    (DeviceOrientationController):
    * loader/PrerendererClient.cpp:
    (WebCore::PrerendererClient::supplementName):
    * loader/PrerendererClient.h:
    (PrerendererClient):
    * page/DOMWindowPagePopup.cpp:
    (WebCore::DOMWindowPagePopup::supplementName):
    * page/DOMWindowPagePopup.h:
    (DOMWindowPagePopup):
    * page/SpeechInput.cpp:
    (WebCore::SpeechInput::supplementName):
    * page/SpeechInput.h:
    (SpeechInput):
    * platform/RefCountedSupplement.h:
    (WebCore::RefCountedSupplement::provideTo):
    (WebCore::RefCountedSupplement::from):
    * platform/Supplementable.h:
    (WebCore):
    (WebCore::Supplement::provideTo):
    (WebCore::Supplement::from):
    (WebCore::Supplementable::provideSupplement):
    (WebCore::Supplementable::removeSupplement):
    (WebCore::Supplementable::requireSupplement):
    (Supplementable):
    * testing/InternalSettings.cpp:
    (WebCore::InternalSettings::supplementName):
    (WebCore):
    (WebCore::InternalSettings::from):
    * testing/InternalSettings.h:
    (InternalSettings):
    
    Source/WebKit/chromium: 
    
    * src/ContextFeaturesClientImpl.cpp:
    (ContextFeaturesCache):
    (WebKit::ContextFeaturesCache::supplementName):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e69ee170