Skip to content
  • commit-queue@webkit.org's avatar
    HTML5 promotes DL from specific 'definition list' to superset 'description... · fe847770
    commit-queue@webkit.org authored
    HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
    https://bugs.webkit.org/show_bug.cgi?id=107650
    
    Source/WebCore:
    
    Patch by James Craig <james@cookiecrook.com> on 2013-01-28
    Reviewed by Chris Fleizach.
    
    Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
    
    Test: platform/mac/accessibility/definition-list-term.html:
    Test: accessibility/lists.html
    
    * English.lproj/Localizable.strings:
    * accessibility/AccessibilityList.cpp:
    (WebCore::AccessibilityList::isDescriptionList):
    * accessibility/AccessibilityList.h:
    (AccessibilityList):
    * accessibility/AccessibilityObject.cpp:
    (WebCore::createARIARoleMap):
    * accessibility/AccessibilityObject.h:
    * accessibility/AccessibilityRenderObject.cpp:
    (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
    * accessibility/mac/WebAccessibilityObjectWrapper.mm:
    (createAccessibilityRoleMap):
    (-[WebAccessibilityObjectWrapper subrole]):
    (-[WebAccessibilityObjectWrapper roleDescription]):
    * platform/LocalizedStrings.cpp:
    (WebCore::AXDefinitionText):
    (WebCore::AXDescriptionListTermText):
    (WebCore):
    (WebCore::AXDescriptionListDetailText):
    * platform/LocalizedStrings.h:
    (WebCore):
    * platform/blackberry/LocalizedStringsBlackBerry.cpp:
    (WebCore::AXDefinitionText):
    (WebCore::AXDescriptionListDetailText):
    (WebCore):
    (WebCore::AXDescriptionListTermText):
    * platform/efl/LocalizedStringsEfl.cpp:
    (WebCore::AXDefinitionText):
    (WebCore):
    (WebCore::AXDescriptionListTermText):
    (WebCore::AXDescriptionListDetailText):
    * platform/gtk/LocalizedStringsGtk.cpp:
    (WebCore::AXDefinitionText):
    (WebCore):
    (WebCore::AXDescriptionListTermText):
    (WebCore::AXDescriptionListDetailText):
    * platform/qt/LocalizedStringsQt.cpp:
    (WebCore::AXDefinitionText):
    (WebCore::AXDescriptionListTermText):
    (WebCore):
    (WebCore::AXDescriptionListDetailText):
    
    Source/WebKit/chromium:
    
    Patch by James Craig <james@cookiecrook.com> on 2013-01-28
    Reviewed by Chris Fleizach.
    
    Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
    
    * public/WebAccessibilityRole.h:
    * src/AssertMatchingEnums.cpp:
    * src/LocalizedStrings.cpp:
    (WebCore::AXDefinitionText):
    (WebCore):
    (WebCore::AXDescriptionListTermText):
    (WebCore::AXDescriptionListDetailText):
    
    Tools:
    
    Patch by James Craig <james@cookiecrook.com> on 2013-01-28
    Reviewed by Chris Fleizach.
    
    Updating accessibility strings and accessors for DL/DT/DD.
    
    * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
    (createDescriptionList):
    * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
    * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
    
    LayoutTests:
    
    Patch by James Craig <james@cookiecrook.com> on 2013-01-28
    Reviewed by Chris Fleizach.
    
    Updating accessibility strings and accessors for DL/DT/DD; new one for [role="definition"] (previously it reused the role/desc for DD).
    Removed gtk expectation as the expectation has changed: platform/gtk/accessibility/lists-expected.txt
    
    * accessibility/lists.html:
    * platform/gtk/accessibility/lists-expected.txt: Removed.
    * platform/mac/accessibility/definition-list-term-expected.txt:
    * platform/mac/accessibility/definition-list-term.html:
    * platform/mac/accessibility/lists-expected.txt:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    fe847770