Skip to content
  • cwzwarich@webkit.org's avatar
    2008-10-03 Cameron Zwarich <zwarich@apple.com> · fde1c9a7
    cwzwarich@webkit.org authored
            Reviewed by Maciej Stachowiak.
    
            Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
            <https://bugs.webkit.org/show_bug.cgi?id=21343>
    
            A fix was landed for this issue in r37253, and the ChangeLog assumes
            that it is a compiler bug, but it turns out that it is a subtle issue
            with mixing signed and unsigned 32-bit values in a 64-bit environment.
            In order to properly fix this bug, we should convert our signed offsets
            into the register file to use ptrdiff_t.
    
            This may not be the only instance of this issue, but I will land this
            fix first and look for more later.
    
            * VM/Machine.cpp:
            (JSC::Machine::getArgumentsData):
            * VM/Machine.h:
            * kjs/Arguments.cpp:
            (JSC::Arguments::getOwnPropertySlot):
            * kjs/Arguments.h:
            (JSC::Arguments::init):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    fde1c9a7