Skip to content
  • ap@webkit.org's avatar
    Reviewed by Darin. · fa4fbed0
    ap@webkit.org authored
            http://bugs.webkit.org/show_bug.cgi?id=15969
            Eliminate Editor::deleteRange()
    
            No change in functionality.
    
    WebCore:
            * editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
    
            * editing/Editor.cpp:
            (WebCore::Editor::deleteWithDirection):
            (WebCore::Editor::cut):
            (WebCore::Editor::performDelete):
            * editing/Editor.h:
            Moved relevant Editor::deleteRange() functionality to its callers.
            Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful
            in my opinion.
    
            * editing/mac/EditorMac.mm:
            (WebCore::initializeKillRingIfNeeded):
            (WebCore::Editor::addToKillRing):
            (WebCore::Editor::yank):
            (WebCore::Editor::yankAndSelect):
            (WebCore::Editor::setMark):
            (WebCore::unionDOMRanges):
            (WebCore::Editor::deleteToMark):
            (WebCore::Editor::selectToMark):
            (WebCore::Editor::swapWithMark):
            Pushed kill ring handling down from WebCore.
    
            * page/mac/WebCoreFrameBridge.h:
            * page/mac/WebCoreFrameBridge.mm:
            Removed setMarkDOMRange (the corresponding getter is still needed).
    
            * WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent().
            Export the new kill ring functions.
    
    WebKit:
            * WebView/WebHTMLView.mm:
            (+[WebHTMLView initialize]):
            (-[WebHTMLView yank:]):
            (-[WebHTMLView yankAndSelect:]):
            (-[WebHTMLView setMark:]):
            (-[WebHTMLView deleteToMark:]):
            (-[WebHTMLView selectToMark:]):
            (-[WebHTMLView swapWithMark:]):
            Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    fa4fbed0