Skip to content
  • kdecker@apple.com's avatar
    i Reviewed by Darin. · f8995e14
    kdecker@apple.com authored
            Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
    
            The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
            function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
            and provide a valid graphics context regardless of whether or not it actually needs to draw. 
            
            * Plugins/WebBaseNetscapePluginView.mm:
            (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. 
            (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes 
            altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f8995e14