Skip to content
  • commit-queue@webkit.org's avatar
    2011-03-21 Chang Shu <cshu@webkit.org> · f52c4946
    commit-queue@webkit.org authored
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            Restore the expected result before r79953. r79953 changed behavior slightly in function
            finishedLoadingWithDataSource in file mac/WebView/WebHTMLRepresentation.mm, where
            core(webFrame)->editor()->applyEditingStyleToBodyElement() was called but not before r79953
            or after this patch.
    
            * platform/mac/editing/selection/designmode-no-caret-expected.txt:
    2011-03-21  Chang Shu  <cshu@webkit.org>
    
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            r79953 removed the WebView level editablity which is persistent no matter whether
            underlying document itself is changed and editability gets lost. The resolution is to
            set this WebView editable value to WebCore. This avoids the callback from WebCore to
            WebKit which was the main goal in r79953 to improve performance.
    
            * WebCore.exp.in:
            * accessibility/AccessibilityRenderObject.cpp:
            (WebCore::AccessibilityRenderObject::isReadOnly):
            * dom/Node.cpp:
            (WebCore::Node::isContentEditable):
            * editing/SelectionController.cpp:
            (WebCore::SelectionController::setSelectionFromNone):
            * page/DragController.cpp:
            (WebCore::DragController::operationForLoad):
            * page/Page.cpp:
            (WebCore::Page::Page):
            * page/Page.h:
            (WebCore::Page::setEditable):
            (WebCore::Page::isEditable):
    2011-03-21  Chang Shu  <cshu@webkit.org>
    
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            r79953 removed the WebView level editablity which is persistent no matter whether
            underlying document itself is changed and editability gets lost. The resolution is to
            set this WebView editable value to WebCore. This avoids the callback from WebCore to
            WebKit which was the main goal in r79953 to improve performance.
    
            * webkit/webkitwebview.cpp:
            (webkit_web_view_get_editable):
            (webkit_web_view_set_editable):
    2011-03-21  Chang Shu  <cshu@webkit.org>
    
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            r79953 removed the WebView level editablity which is persistent no matter whether
            underlying document itself is changed and editability gets lost. The resolution is to
            set this WebView editable value to WebCore. This avoids the callback from WebCore to
            WebKit which was the main goal in r79953 to improve performance.
    
            * WebView/WebView.mm:
            (-[WebView setEditable:]):
            (-[WebView isEditable]):
    2011-03-21  Chang Shu  <cshu@webkit.org>
    
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            r79953 removed the WebView level editablity which is persistent no matter whether
            underlying document itself is changed and editability gets lost. The resolution is to
            set this WebView editable value to WebCore. This avoids the callback from WebCore to
            WebKit which was the main goal in r79953 to improve performance.
    
            * Api/qwebpage.cpp:
            (QWebPage::setContentEditable):
            (QWebPage::isContentEditable):
    2011-03-21  Chang Shu  <cshu@webkit.org>
    
            Reviewed by Alexey Proskuryakov.
    
            REGRESSION (r79953): Can't type in MS Outlook 2011
            https://bugs.webkit.org/show_bug.cgi?id=56665
    
            r79953 removed the WebView level editablity which is persistent no matter whether
            underlying document itself is changed and editability gets lost. The resolution is to
            set this WebView editable value to WebCore. This avoids the callback from WebCore to
            WebKit which was the main goal in r79953 to improve performance.
    
            * WebFrame.cpp:
            (wxWebFrame::MakeEditable):
            (wxWebFrame::IsEditable):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f52c4946