Skip to content
  • benjamin@webkit.org's avatar
    Do not do any logging initialization when logging is disabled · f3869e43
    benjamin@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=90228
    
    Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-02
    Reviewed by Simon Fraser.
    
    Source/WebCore: 
    
    Initializating of the logging channels was taking time on startup. When logging is disabled
    (and the LOG macro does nothing), we should aslo disable logging channels and initialization.
    
    This patch #ifdef the Logging initialization with the macro LOG_DISABLED.
    
    * WebCore.exp.in:
    * make-export-file-generator: Explicitely adds Assertions.h so that LOG_DISABLED is defined.
    * platform/Logging.cpp:
    * platform/Logging.h:
    * platform/blackberry/LoggingBlackBerry.cpp:
    * platform/efl/LoggingEfl.cpp:
    * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    * platform/gtk/LoggingGtk.cpp:
    * platform/mac/LoggingMac.mm:
    * platform/network/soup/ResourceHandleSoup.cpp:
    (WebCore::ensureSessionIsInitialized):
    * platform/qt/LoggingQt.cpp:
    * platform/win/LoggingWin.cpp:
    * platform/wx/LoggingWx.cpp:
    
    Source/WebKit/blackberry: 
    
    * Api/BlackBerryGlobal.cpp:
    (BlackBerry::WebKit::globalInitialize):
    
    Source/WebKit/chromium: 
    
    * src/WebKit.cpp:
    (WebKit::enableLogChannel):
    
    Source/WebKit/efl: 
    
    * ewk/ewk_main.cpp:
    (_ewk_init_body):
    
    Source/WebKit/gtk: 
    
    * webkit/webkitglobals.cpp:
    (webkitInit):
    
    Source/WebKit/mac: 
    
    * Misc/WebIconDatabase.mm:
    (-[WebIconDatabase _scaleIcon:toSize:]):
    * Misc/WebKitLogging.h:
    * Misc/WebKitLogging.m:
    * WebView/WebHTMLView.mm:
    (-[WebHTMLView _attributeStringFromDOMRange:]):
    * WebView/WebView.mm:
    (-[WebView _commonInitializationWithFrameName:groupName:]):
    
    Source/WebKit/qt: 
    
    * WebCoreSupport/InitWebCoreQt.cpp:
    (WebCore::initializeWebCoreQt):
    
    Source/WebKit/win: 
    
    * WebView.cpp:
    (WebView::initWithFrame):
    
    Source/WebKit/wx: 
    
    * WebView.cpp:
    (WebKit::WebView::Create):
    
    Source/WebKit2: 
    
    * Platform/Logging.cpp:
    * Platform/Logging.h:
    * UIProcess/WebContext.cpp:
    (WebKit::WebContext::WebContext):
    * WebProcess/WebProcess.cpp:
    (WebKit::WebProcess::WebProcess):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f3869e43