Skip to content
  • wjmaclean@chromium.org's avatar
    [chromium] Enhance support for transforms in LinkHighlight. · f28e98cd
    wjmaclean@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=94355
    
    Reviewed by Adrienne Walker.
    
    Improved handling of transformed highlight targets, where the transform goes beyond simple translation.
    
    Source/WebKit/chromium:
    
    * src/LinkHighlight.cpp:
    (WebKit::convertTargetSpaceQuadToCompositedLayer): Converts target space quad to composited layer coordinates.
    (WebKit):
    (WebKit::addQuadToPath): Supports adding non-rectilinear quads to Path.
    (WebKit::LinkHighlight::computeHighlightLayerPathAndPosition): Updated to deal with target's quadlist, transform individual quads according to transforms.
    * src/WebViewImpl.cpp:
    (WebKit::WebViewImpl::bestTouchLinkNode):
    
    LayoutTests:
    
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html: Added.
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div.html: Added.
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link.html: Added.
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX.html: Added.
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY.html: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.png: Removed.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-ZIndex-expected.txt: Removed.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line-expected.txt: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-div-expected.txt: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-rotated-link-expected.txt: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledX-expected.txt: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-scaledY-expected.txt: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f28e98cd