Skip to content
  • weinig@apple.com's avatar
    Implement __lookupGetter__/__lookupSetter__ in terms of getPropertyDescriptor · f16c8bee
    weinig@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=71336
    
    Reviewed by Darin Adler.
    
    Source/JavaScriptCore: 
    
    * debugger/DebuggerActivation.cpp:
    * debugger/DebuggerActivation.h:
    Remove overrides of lookupGetter/lookupSetter, which are no longer needed
    due to implementing getPropertyDescriptor.
    
    * runtime/JSObject.cpp:
    (JSC::JSObject::lookupGetter):
    (JSC::JSObject::lookupSetter):
    * runtime/JSObject.h:
    De-virtualize lookupGetter/lookupSetter, and implement them in terms of
    getPropertyDescriptor.
    
    Source/WebCore: 
    
    * bindings/js/JSDOMWindowCustom.cpp:
    * bindings/js/JSDOMWindowShell.cpp:
    * bindings/js/JSDOMWindowShell.h:
    * page/DOMWindow.idl:
    Remove overrides of lookupGetter/lookupSetter, which are no longer needed
    due to implementing getPropertyDescriptor.
    
    LayoutTests: 
    
    * fast/dom/getter-on-window-object2-expected.txt:
    Update results now that __lookupGetter__/__lookupSetter__ match getOwnPropertyDescriptor.
    The failures are tracked by https://bugs.webkit.org/show_bug.cgi?id=71333.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    f16c8bee