Skip to content
  • bfulgham@apple.com's avatar
    [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification · 185ed0dd
    bfulgham@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=126754
    
    Patch by Dean Jackson <dino@apple.com> on 2014-01-11
    Reviewed by Filip Pizlo.
    
    Source/JavaScriptCore: 
    
    The ECMAScript specification forbids calling the typed array
    constructors without using "new". Change the call data to return
    none so we throw and exception in these cases.
    
    * runtime/JSGenericTypedArrayViewConstructorInlines.h:
    (JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):
    
    LayoutTests: 
    
    New test which checks that we throw an exception when calling
    any of the typed array constructors without using "new".
    
    * js/script-tests/typedarray-constructors.js: Added.
    * js/typedarray-constructors-expected.txt: Added.
    * js/typedarray-constructors.html: Added.
    * resources/standalone-pre.js: Add missing 'shouldNotThrow'
    method (duplicated from resources/js-test-pre.js)
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@161789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    185ed0dd