Skip to content
  • commit-queue@webkit.org's avatar
    Source/JavaScriptCore: Fixed a few llint C++ interpreter bugs. · 88e66d6d
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=96127.
    
    Patch by Mark Lam <mark.lam@apple.com> on 2012-09-09
    Reviewed by Geoffrey Garen.
    
    * llint/LLIntCLoop.h:
        CLoop::execute()'s bootstrapOpcodeId does not need a default
        value. There is no case when this function is called without
        that parameter being specified.
    * llint/LowLevelInterpreter.asm:
        Moved the dispatchAfterCall() call to where it is needed.
        For the C_LOOP back-end, it generates unreachable code.
    * llint/LowLevelInterpreter.cpp:
        #include <wtf/Assertions.h> because LLIntAssembly.h needs it.
    (JSC):
        Fixed bug in SIGN_BIT32() macro.
        Placate a MSVC warning for t0, and t1 being uninitialized.
    (JSC::CLoop::execute):
        The bootstrapOpcodeId arg should always be specified.
        MSVC doesn't like UNUSED_PARAM() for labels. Switch to using
            the new UNUSED_LABEL() macro.
    * offlineasm/cloop.rb:
    * offlineasm/generate_offset_extractor.rb:
        Resolved a compiler warning found via MSVC.
    
    Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
    comma expressions. Also, added UNUSED_LABEL().
    https://bugs.webkit.org/show_bug.cgi?id=96127.
    
    Patch by Mark Lam <mark.lam@apple.com> on 2012-09-09
    Reviewed by Geoffrey Garen.
    
    * wtf/Assertions.h:
    * wtf/UnusedParam.h: Added UNUSED_LABEL(). Removed an obsolete comment.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    88e66d6d