Skip to content
  • kaustubh@motorola.com's avatar
    Notification.requestPermission callback should be optional · ecf7eefb
    kaustubh@motorola.com authored
    https://bugs.webkit.org/show_bug.cgi?id=108196
    
    Reviewed by Kentaro Hara.
    
    Spec says it should be optional.
    http://notifications.spec.whatwg.org/#notification
    
    Source/WebCore:
    
    Test: fast/notifications/notifications-request-permission-optional.html
    
    * GNUmakefile.list.am:
    * Modules/notifications/Notification.h:
    (Notification):
    * Modules/notifications/Notification.idl:
    * Modules/notifications/NotificationCenter.cpp:
    (WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
    * Modules/notifications/NotificationCenter.h:
    (NotificationCenter):
    * Modules/notifications/NotificationCenter.idl:
    * Target.pri:
    * UseJSC.cmake:
    * UseV8.cmake:
    * WebCore.gypi:
    * WebCore.vcproj/WebCore.vcproj:
    * WebCore.vcxproj/WebCore.vcxproj:
    * WebCore.vcxproj/WebCore.vcxproj.filters:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/JSBindingsAllInOne.cpp:
    * bindings/js/JSDesktopNotificationsCustom.cpp: Removed.
    * bindings/js/JSNotificationCustom.cpp: Removed.
    * bindings/scripts/CodeGeneratorJS.pm:
    (GenerateParametersCheck):
    * bindings/v8/custom/V8NotificationCenterCustom.cpp: Removed.
    * bindings/v8/custom/V8NotificationCustom.cpp: Removed.
    
    LayoutTests:
    
    * fast/notifications/notifications-request-permission-optional-expected.txt: Added.
    * fast/notifications/notifications-request-permission-optional.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ecf7eefb