Skip to content
  • ggaren's avatar
    JavaScriptCore: · ec60d104
    ggaren authored
            Reviewed by Anders Carlsson.
    
            Even more cleanup in preparation for fixing <rdar://problem/4608404> 
            WebScriptObject's _executionContext lack of ownership policy causes 
            crashes (e.g., in Dashcode)
            
            Layout tests pass.
            
            Renames:
                findRootObjectForNativeHandleFunction => createRootObject
                FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction
                
            Also removed unnecessary use of "Bindings::" prefix.
    
            * JavaScriptCore.exp:
            * bindings/jni/jni_jsobject.cpp:
            (JavaJSObject::createNative):
            (JavaJSObject::convertValueToJObject):
            (JavaJSObject::convertJObjectToValue):
            * bindings/runtime_root.cpp:
            (KJS::Bindings::RootObject::setCreateRootObject):
            * bindings/runtime_root.h:
            (KJS::Bindings::RootObject::createRootObject):
    
    WebCore:
    
            Reviewed by Anders Carlsson.
            
            Even more cleanup in preparation for fixing <rdar://problem/4608404> 
            WebScriptObject's _executionContext lack of ownership policy causes 
            crashes (e.g., in Dashcode)
            
            Layout tests pass.
            
            Renames:
                findRootObjectForNativeHandleFunction => createRootObject
                FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
                rootForView => createRootObject
                getInstanceForView => getPluginInstanceForWidget
    
            * page/mac/FrameMac.mm:
            (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
            variable named "nativeHandle" to be more explicit about the fact that JavaScript's
            "nativeHandle" is just an NSView *.
    
            (WebCore::getPluginInstanceForWidget): This function now does the NSView *
            fetching that its callers used to do.
            (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
            (WebCore::FrameMac::getObjectInstanceForWidget): ditto
    
            * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
            which was really more of a shmategory.
            (createRootObject): Removed rootObjectForView, folding it into its only
            caller, the similarly named rootForView. Renamed the pair to "createRootObject"
            because that's what they do.
    
            (-[WebCoreFrameBridge init]): Updated for renames
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ec60d104