Skip to content
  • wjmaclean@chromium.org's avatar
    [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and... · eb4ecaa5
    wjmaclean@chromium.org authored
    [chromium] Modify gesture highlight behaviour. Cancel on GestureLongPress and animate on GestureTapCancel.
    https://bugs.webkit.org/show_bug.cgi?id=97355
    
    Reviewed by Adrienne Walker.
    
    This patch revises the behaviour of GestureTapDown highlighting so that the highlight should disappear if
    interrupted by GestureTap, and animate away if interrupted by GestureTapCancel.
    
    Source/WebKit/chromium:
    
    * src/LinkHighlight.cpp:
    (WebKit::LinkHighlight::LinkHighlight):
    (WebKit::LinkHighlight::startHighlightAnimationIfNeeded):
    * src/LinkHighlight.h:
    (LinkHighlight):
    * src/WebViewImpl.cpp:
    (WebKit::WebViewImpl::handleGestureEvent):
    (WebKit::WebViewImpl::enableTouchHighlight):
    
    LayoutTests:
    
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel.html: removed extra testRunner.display().
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2.html: Added.
    * platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress.html: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-cancel2-expected.txt: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.png: Added.
    * platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-longPress-expected.txt: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    eb4ecaa5