Skip to content
  • jsbell@chromium.org's avatar
    IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError · e9e60209
    jsbell@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=103759
    
    Reviewed by Darin Fisher.
    
    Source/WebCore:
    
    Now that IDBDatabaseException isn't exposed to script with constants, the exception types
    can be renamed to match the much friendlier names used in newer iterations of the spec. Also
    remove the legacy/unused types.
    
    No new tests, just constant renames.
    
    * Modules/indexeddb/IDBCursor.cpp:
    (WebCore::IDBCursor::update):
    (WebCore::IDBCursor::advance):
    (WebCore::IDBCursor::continueFunction):
    (WebCore::IDBCursor::deleteFunction):
    * Modules/indexeddb/IDBCursorBackendImpl.cpp:
    (WebCore::IDBCursorBackendImpl::continueFunction):
    (WebCore::IDBCursorBackendImpl::advance):
    (WebCore::IDBCursorBackendImpl::prefetchContinue):
    * Modules/indexeddb/IDBDatabase.cpp:
    (WebCore::IDBDatabase::createObjectStore):
    (WebCore::IDBDatabase::deleteObjectStore):
    (WebCore::IDBDatabase::transaction):
    * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
    (WebCore::IDBDatabaseBackendImpl::createObjectStore):
    (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
    (WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
    (WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
    (WebCore::IDBDatabaseBackendImpl::openConnection):
    (WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
    (WebCore::IDBDatabaseBackendImpl::deleteDatabase):
    (WebCore::IDBDatabaseBackendImpl::close):
    * Modules/indexeddb/IDBDatabaseException.cpp: Tidying and renaming.
    (WebCore):
    (WebCore::getErrorEntry):
    * Modules/indexeddb/IDBDatabaseException.h:
    * Modules/indexeddb/IDBFactory.cpp:
    (WebCore::IDBFactory::cmp):
    * Modules/indexeddb/IDBFactoryBackendImpl.cpp:
    (WebCore::IDBFactoryBackendImpl::getDatabaseNames):
    (WebCore::IDBFactoryBackendImpl::deleteDatabase):
    (WebCore::IDBFactoryBackendImpl::open):
    * Modules/indexeddb/IDBIndex.cpp:
    (WebCore::IDBIndex::openCursor):
    (WebCore::IDBIndex::count):
    (WebCore::IDBIndex::openKeyCursor):
    (WebCore::IDBIndex::get):
    (WebCore::IDBIndex::getKey):
    * Modules/indexeddb/IDBIndexBackendImpl.cpp:
    (WebCore::IDBIndexBackendImpl::openCursor):
    (WebCore::IDBIndexBackendImpl::openKeyCursor):
    (WebCore::IDBIndexBackendImpl::count):
    (WebCore::IDBIndexBackendImpl::get):
    (WebCore::IDBIndexBackendImpl::getKey):
    * Modules/indexeddb/IDBKeyRange.cpp:
    (WebCore::IDBKeyRange::only):
    (WebCore::IDBKeyRange::lowerBound):
    (WebCore::IDBKeyRange::upperBound):
    (WebCore::IDBKeyRange::bound):
    * Modules/indexeddb/IDBObjectStore.cpp:
    (WebCore::IDBObjectStore::get):
    (WebCore::IDBObjectStore::put):
    (WebCore::IDBObjectStore::deleteFunction):
    (WebCore::IDBObjectStore::clear):
    (WebCore):
    (WebCore::IDBObjectStore::createIndex):
    (WebCore::IDBObjectStore::index):
    (WebCore::IDBObjectStore::deleteIndex):
    (WebCore::IDBObjectStore::openCursor):
    (WebCore::IDBObjectStore::count):
    * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
    (WebCore::IDBObjectStoreBackendImpl::get):
    (WebCore::IDBObjectStoreBackendImpl::put):
    (WebCore):
    (WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
    (WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
    (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
    (WebCore::IDBObjectStoreBackendImpl::clear):
    (WebCore::IDBObjectStoreBackendImpl::createIndex):
    (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
    (WebCore::IDBObjectStoreBackendImpl::openCursor):
    (WebCore::IDBObjectStoreBackendImpl::count):
    * Modules/indexeddb/IDBOpenDBRequest.cpp:
    (WebCore::IDBOpenDBRequest::dispatchEvent):
    * Modules/indexeddb/IDBRequest.cpp:
    (WebCore::IDBRequest::result):
    (WebCore::IDBRequest::error):
    (WebCore::IDBRequest::errorCode):
    (WebCore::IDBRequest::webkitErrorMessage):
    (WebCore::IDBRequest::abort):
    (WebCore::IDBRequest::dispatchEvent):
    (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
    * Modules/indexeddb/IDBTransaction.cpp:
    (WebCore::IDBTransaction::objectStore):
    (WebCore::IDBTransaction::abort):
    * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
    (WebCore::IDBTransactionBackendImpl::objectStore):
    (WebCore::IDBTransactionBackendImpl::abort):
    (WebCore::IDBTransactionBackendImpl::commit):
    
    Source/WebKit/chromium:
    
    Update IDBDatabaseException enum names/values to match WebCore.
    
    * public/WebIDBDatabaseException.h:
    * src/AssertMatchingEnums.cpp:
    * src/IDBFactoryBackendProxy.cpp:
    (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
    * tests/IDBRequestTest.cpp:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@136417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e9e60209