• commit-queue@webkit.org's avatar
    Crashes in WebCore::AppendNodeCommand::create(). · e7d6fb2a
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=67767
    
    Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node.
    The current code assumes lastNode is an Element node. This patch checks it.
    
    Test: editing/execCommand/ident-crashes-topnode-is-text.html
    
    * editing/CompositeEditCommand.cpp:
    (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check.
    
    LayoutTests:
    
    Added a crash test case.
    
    * editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added.
    * editing/execCommand/ident-crashes-topnode-is-text.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e7d6fb2a
CompositeEditCommand.cpp 54.3 KB