Skip to content
  • leviw@chromium.org's avatar
    unicode-bidi:plaintext is supposed to be effective on display:inline elements too · e7812f3d
    leviw@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=73310
    
    Reviewed by Eric Seidel.
    
    Source/WebCore:
    
    Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
    like unicode-bidi: isolate with the addition of their directionality being determined
    by the UBA.
    
    Tests: fast/text/international/inline-plaintext-is-isolated-expected.html
           fast/text/international/inline-plaintext-is-isolated.html
           fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
           fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
           fast/text/international/inline-plaintext-with-generated-content-expected.html
           fast/text/international/inline-plaintext-with-generated-content.html
    
    * platform/text/UnicodeBidi.h:
    (WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
    are both treated as isolated content.
    * rendering/InlineIterator.h:
    (WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
    (WebCore::notifyObserverWillExitObject): Ditto.
    (WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
    (WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::determineDirectionality): Generalized for inlines.
    (WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
    (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
    (WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
    bidiFirstSkippingEmptyInlines.
    
    LayoutTests:
    
    Ref tests for unicode-bidi: plaintext on inlines.
    
    * fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
    * fast/text/international/inline-plaintext-is-isolated.html: Added.
    * fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
    * fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
    * fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
    * fast/text/international/inline-plaintext-with-generated-content.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e7812f3d