Skip to content
  • dglazkov@chromium.org's avatar
    WebCore: Added notification when the favicons for a page are changed · e5916262
    dglazkov@chromium.org authored
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    Test: fast/dom/icon-url-property.html
    
    * dom/Document.cpp:
    (WebCore::Document::setIconURL):
    * loader/DocumentLoader.cpp:
    (WebCore::DocumentLoader::setIconURL):
    * loader/DocumentLoader.h:
    (WebCore::DocumentLoader::iconURL):
    * loader/EmptyClients.h:
    (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
    * loader/FrameLoader.cpp:
    (WebCore::FrameLoader::setIconURL):
    (WebCore::FrameLoader::didChangeIcons):
    * loader/FrameLoader.h:
    * loader/FrameLoaderClient.h:
    
    WebKit/chromium: Added notification when the favicons for a page are changed
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * public/WebFrameClient.h:
    (WebKit::WebFrameClient::didChangeIcons):
    * src/FrameLoaderClientImpl.cpp:
    (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
    * src/FrameLoaderClientImpl.h:
    
    WebKit/gtk: Added notification when the favicons for a page are changed
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * WebCoreSupport/FrameLoaderClientGtk.cpp:
    (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
    * WebCoreSupport/FrameLoaderClientGtk.h:
    
    WebKit/mac: Added notification when the favicons for a page are changed
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * WebCoreSupport/WebFrameLoaderClient.h:
    * WebCoreSupport/WebFrameLoaderClient.mm:
    (WebFrameLoaderClient::dispatchDidChangeIcons):
    
    WebKit/qt: Added notification when the favicons for a page are changed
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * WebCoreSupport/FrameLoaderClientQt.cpp:
    (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
    (WebCore::FrameLoaderClientQt::didChangeTitle):
    * WebCoreSupport/FrameLoaderClientQt.h:
    
    WebKit/win: Added notification when the favicons for a page are changed
    from a script.
    The Document object will notify the frame loader, which will
    notify the client. Implementations of FrameLoaderClient will
    have to add one method; dispatchDidChangeIcons().
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
    * WebCoreSupport/WebFrameLoaderClient.cpp:
    (WebFrameLoaderClient::dispatchDidChangeIcons):
    * WebCoreSupport/WebFrameLoaderClient.h:
    * WebFrame.cpp:
    (WebFrame::didChangeIcons):
    * WebFrame.h:
    
    WebKitTools: Add test support for icon changes.
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * DumpRenderTree/LayoutTestController.cpp:
    (LayoutTestController::LayoutTestController):
    (dumpIconChangesCallback):
    (LayoutTestController::staticFunctions):
    * DumpRenderTree/LayoutTestController.h:
    (LayoutTestController::dumpIconChanges):
    (LayoutTestController::setDumpIconChanges):
    * DumpRenderTree/win/FrameLoadDelegate.cpp:
    (FrameLoadDelegate::didChangeIcons):
    * DumpRenderTree/win/FrameLoadDelegate.h:
    * WinLauncher/WinLauncher.h:
    (WinLauncherWebHost::didChangeIcons):
    
    LayoutTests: Add test for icon change notifications.
    
    Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
    Reviewed by Dimitri Glazkov.
    
    https://bugs.webkit.org/show_bug.cgi?id=33812
    
    * fast/dom/icon-url-property-expected.txt: Added.
    * fast/dom/icon-url-property.html: Added.
    * Skipped on all platforms but Win
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e5916262