Skip to content
  • kbr@google.com's avatar
    2010-03-17 Kenneth Russell <kbr@google.com> · e34ffedc
    kbr@google.com authored
            Reviewed by Darin Fisher.
    
            Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
            https://bugs.webkit.org/show_bug.cgi?id=36233
    
            The patch for bug 33416, which added multisampling support to the
            WebGL back buffer, uncovered some OpenGL driver bugs on the build
            bots which need further investigation to determine the appropriate
            workaround. Reverting this change, the minor build fix in 36189,
            and the skipping of the affected tests in bug 36200.
    
            Built and tested WebKit and Chromium and ran all WebGL layout
            tests in both.
    
            * src/GraphicsContext3D.cpp:
            (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
            (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
            (WebCore::GraphicsContext3DInternal::reshape):
            (WebCore::GraphicsContext3DInternal::beginPaint):
            (WebCore::GraphicsContext3DInternal::bindFramebuffer):
            (WebCore::GraphicsContext3D::readPixels):
    2010-03-17  Kenneth Russell  <kbr@google.com>
    
            Reviewed by Darin Fisher.
    
            Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
            https://bugs.webkit.org/show_bug.cgi?id=36233
    
            The patch for bug 33416, which added multisampling support to the
            WebGL back buffer, uncovered some OpenGL driver bugs on the build
            bots which need further investigation to determine the appropriate
            workaround. Reverting this change, the minor build fix in 36189,
            and the skipping of the affected tests in bug 36200.
    
            Built and tested WebKit and Chromium and ran all WebGL layout
            tests in both.
    
            * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
            (WebCore::V8HTMLCanvasElement::getContextCallback):
            * platform/graphics/GraphicsContext3D.h:
            * platform/graphics/mac/Canvas3DLayer.h:
            * platform/graphics/mac/Canvas3DLayer.mm:
            (-[Canvas3DLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]):
            * platform/graphics/mac/GraphicsContext3DMac.cpp:
            (WebCore::GraphicsContext3D::GraphicsContext3D):
            (WebCore::GraphicsContext3D::~GraphicsContext3D):
            (WebCore::GraphicsContext3D::reshape):
            (WebCore::GraphicsContext3D::bindFramebuffer):
            (WebCore::GraphicsContext3D::readPixels):
            * platform/graphics/mac/GraphicsLayerCA.mm:
            (WebCore::GraphicsLayerCA::setContentsToGraphicsContext3D):
    2010-03-17  Kenneth Russell  <kbr@google.com>
    
            Reviewed by Darin Fisher.
    
            Revert WebGL context attributes changes 33416 / r56074 and 36200 / r56093
            https://bugs.webkit.org/show_bug.cgi?id=36233
    
            The patch for bug 33416, which added multisampling support to the
            WebGL back buffer, uncovered some OpenGL driver bugs on the build
            bots which need further investigation to determine the appropriate
            workaround. Reverting this change, the minor build fix in 36189,
            and the skipping of the affected tests in bug 36200.
    
            Built and tested WebKit and Chromium and ran all WebGL layout
            tests in both.
    
            * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt: Removed.
            * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Removed.
            * fast/canvas/webgl/context-attributes-expected.txt:
            * fast/canvas/webgl/context-attributes.html:
            * fast/canvas/webgl/gl-get-calls-expected.txt:
            * fast/canvas/webgl/gl-get-calls.html:
            * platform/mac/Skipped:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    e34ffedc