Skip to content
  • timothy@apple.com's avatar
    Avoid making a window for the Web Inspector when it is docked. · dc0c6308
    timothy@apple.com authored
    This also makes sure the inspector WKView is in a window before the page is loaded.
    This avoids some redundant work caused by moving it to a window later.
    
    https://webkit.org/b/78064
    
    Reviewed by Brian Weinstein.
    
    * UIProcess/WebInspectorProxy.cpp:
    (WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
    (WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
    * UIProcess/WebInspectorProxy.h:
    (WebInspectorProxy):
    * UIProcess/mac/WebInspectorProxyMac.mm:
    (WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
    (WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
    (WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
    (WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
    (WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
    (WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
    (WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
    (WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
    (WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    dc0c6308