• darin@apple.com's avatar
    JavaScriptCore: · d5ceaf86
    darin@apple.com authored
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more of https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * kjs/nodes.cpp:
            (KJS::ParserRefCounted::hasOneRef): Added. Replaces refcount.
            * kjs/nodes.h: Replaced refcount with hasOneRef.
    
            * wtf/ListRefPtr.h:
            (WTF::ListRefPtr::~ListRefPtr): Changed to use hasOneRef instead of
            refcount, so this class can be used with the RefCounted template.
    
            * wtf/RefCounted.h:
            (WTF::RefCounted::hasOneRef): Made const, since there's no reason for
            it to be non-const.
    
    WebCore:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * WebCore.base.exp: Added some new exports needed for functions that are now
            non-virtual.
    
            * WebCore.xcodeproj/project.pbxproj: Moved the "icon" group to the correct
            location in the project. Before it was inside "appcache"!
    
            * css/CSSStyleSelector.cpp:
            (WebCore::CSSStyleSelector::applyProperty):
            * dom/Clipboard.cpp:
            (WebCore::Clipboard::Clipboard):
            * editing/mac/EditorMac.mm:
            (WebCore::Editor::newGeneralClipboard):
            * editing/qt/EditorQt.cpp:
            (WebCore::Editor::newGeneralClipboard):
            * editing/wx/EditorWx.cpp:
            (WebCore::Editor::newGeneralClipboard):
            * loader/DocumentLoader.cpp:
            (WebCore::DocumentLoader::DocumentLoader):
            * loader/DocumentLoader.h:
            (WebCore::DocumentLoader::create):
            * loader/icon/IconDatabase.cpp:
            (WebCore::IconDatabase::defaultIcon):
            (WebCore::IconDatabase::setIconDataForIconURL):
            (WebCore::IconDatabase::setIconURLForPageURL):
            (WebCore::IconDatabase::getOrCreateIconRecord):
            (WebCore::IconDatabase::performURLImport):
            * loader/icon/IconDatabase.h:
            * loader/icon/IconRecord.cpp:
            (WebCore::IconRecord::IconRecord):
            * loader/icon/IconRecord.h:
            (WebCore::IconRecord::create):
            * page/EventHandler.h:
            * page/Frame.cpp:
            (WebCore::Frame::Frame):
            * page/Frame.h:
            (WebCore::Frame::create):
            * page/gtk/EventHandlerGtk.cpp:
            (WebCore::EventHandler::createDraggingClipboard):
            * page/mac/EventHandlerMac.mm:
            (WebCore::EventHandler::createDraggingClipboard):
            * page/qt/EventHandlerQt.cpp:
            (WebCore::EventHandler::createDraggingClipboard):
            * page/win/EventHandlerWin.cpp:
            (WebCore::EventHandler::createDraggingClipboard):
            * page/wx/EventHandlerWx.cpp:
            (WebCore::EventHandler::createDraggingClipboard):
            * platform/Cursor.h:
            (WebCore::SharedCursor::create):
            (WebCore::SharedCursor::~SharedCursor):
            (WebCore::SharedCursor::SharedCursor):
            * platform/DragData.h:
            * platform/PopupMenu.h:
            (WebCore::PopupMenu::create):
            (WebCore::PopupMenu::isActive):
            * platform/ScrollBar.cpp:
            (WebCore::Scrollbar::Scrollbar):
            * platform/SearchPopupMenu.h:
            (WebCore::SearchPopupMenu::create):
            * platform/graphics/FontFamily.cpp:
            (WebCore::FontFamily::FontFamily):
            (WebCore::operator==):
            * platform/graphics/FontFamily.h:
            (WebCore::FontFamily::FontFamily):
            (WebCore::SharedFontFamily::create):
            (WebCore::SharedFontFamily::SharedFontFamily):
            (WebCore::operator!=):
            (WebCore::FontFamily::next):
            (WebCore::FontFamily::appendFamily):
            (WebCore::FontFamily::releaseNext):
            * platform/graphics/Icon.h:
            * platform/graphics/gtk/IconGtk.cpp:
            (WebCore::Icon::Icon):
            (WebCore::Icon::~Icon):
            (WebCore::Icon::newIconForFile):
            * platform/graphics/mac/IconMac.mm:
            (WebCore::Icon::Icon):
            (WebCore::Icon::newIconForFile):
            * platform/graphics/qt/IconQt.cpp:
            (WebCore::Icon::Icon):
            (WebCore::Icon::newIconForFile):
            * platform/graphics/win/IconWin.cpp:
            (WebCore::Icon::Icon):
            (WebCore::Icon::~Icon):
            (WebCore::Icon::newIconForFile):
            * platform/gtk/ClipboardGtk.cpp:
            (WebCore::Editor::newGeneralClipboard):
            * platform/gtk/ClipboardGtk.h:
            (WebCore::ClipboardGtk::create):
            * platform/gtk/PlatformScrollBar.h:
            (WebCore::PlatformScrollbar::create):
            * platform/gtk/PopupMenuGtk.cpp:
            (WebCore::PopupMenu::PopupMenu):
            * platform/gtk/ScrollViewGtk.cpp:
            (WebCore::ScrollViewScrollbar::create):
            (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
            (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
            * platform/mac/ClipboardMac.h:
            (WebCore::ClipboardMac::create):
            * platform/mac/DragDataMac.mm:
            (WebCore::DragData::createClipboard):
            (WebCore::DragData::containsCompatibleContent):
            * platform/mac/PlatformScrollBar.h:
            (WebCore::PlatformScrollbar::create):
            (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
            (WebCore::PlatformScrollbar::verticalScrollbarWidth):
            * platform/mac/PopupMenuMac.mm:
            (WebCore::PopupMenu::PopupMenu):
            * platform/qt/ClipboardQt.h:
            (WebCore::ClipboardQt::create):
            * platform/qt/DragDataQt.cpp:
            (WebCore::DragData::createClipboard):
            * platform/qt/PlatformScrollBar.h:
            (WebCore::PlatformScrollbar::create):
            * platform/qt/PopupMenuQt.cpp:
            (WebCore::PopupMenu::PopupMenu):
            * platform/qt/ScrollViewQt.cpp:
            (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
            (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
            * platform/win/ClipboardWin.h:
            (WebCore::ClipboardWin::create):
            * platform/win/CursorWin.cpp:
            (WebCore::Cursor::Cursor):
            (WebCore::loadSharedCursor):
            * platform/win/DragDataWin.cpp:
            (WebCore::DragData::createClipboard):
            * platform/win/EditorWin.cpp:
            (WebCore::Editor::newGeneralClipboard):
            * platform/win/PlatformScrollBar.h:
            (WebCore::PlatformScrollbar::create):
            * platform/win/PopupMenuWin.cpp:
            (WebCore::PopupMenu::PopupMenu):
            (WebCore::PopupMenu::show):
            * platform/win/ScrollViewWin.cpp:
            (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
            (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar):
            * platform/wx/ClipboardWx.h:
            (WebCore::ClipboardWx::create):
            * platform/wx/PlatformScrollBar.h:
            (WebCore::PlatformScrollbar::create):
            * platform/wx/PopupMenuWx.cpp:
            (WebCore::PopupMenu::PopupMenu):
            * platform/wx/TemporaryLinkStubs.cpp:
            (Icon::Icon):
            (Icon::newIconForFile):
            * rendering/RenderLayer.cpp:
            (WebCore::RenderLayer::createScrollbar):
            * rendering/RenderListBox.cpp:
            (WebCore::RenderListBox::updateFromElement):
            * svg/graphics/SVGImage.cpp:
            (WebCore::SVGImage::dataChanged):
            * svg/graphics/SVGImageEmptyClients.h:
            (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
    
    WebKit/gtk:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * WebCoreSupport/FrameLoaderClientGtk.cpp:
            (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new.
            * webkit/webkitwebframe.cpp:
            (webkit_web_frame_new): Ditto.
            (webkit_web_frame_init_with_web_view): Ditto.
    
    WebKit/mac:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more of https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * WebCoreSupport/WebFrameLoaderClient.mm:
            (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
            (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
            a ref call inside the Frame constructor. The lifetime rules for Frame are now the
            conventional ones without a special case.
    
            * WebView/WebDataSource.mm:
            (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
            this function takes ownership of the DocumentLoader.
            (-[WebDataSource initWithRequest:]): Use create instead of new.
            * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
            PassRefPtr and also cleaned up the header a bit.
    
            * WebView/WebDocumentLoaderMac.h:
            (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
            functions private.
    
            * WebView/WebFrame.mm:
            (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
            of new.
    
    WebKit/qt:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * Api/qwebframe.cpp:
            (QWebFramePrivate::init): Use create instead of new.
            * WebCoreSupport/FrameLoaderClientQt.cpp:
            (WebCore::FrameLoaderClientQt::createDocumentLoader): Ditto.
    
    WebKit/win:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more of https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * WebCoreSupport/WebFrameLoaderClient.cpp:
            (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
            a ref call inside the Frame constructor. The lifetime rules for Frame are now the
            conventional ones without a special case.
    
            * WebFrame.cpp:
            (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
            IWebFrameView argument (every caller was passing 0). Also changed this to return the
            WebCore Frame object, which is needed to straighten out the lifetime and ownership
            issues.
            * WebFrame.h: Ditto.
    
            * WebView.cpp:
            (WebView::initWithFrame): Changed to call new init function and use the return value.
    
    WebKit/wx:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Sam.
    
            - more https://bugs.webkit.org/show_bug.cgi?id=17257
              start ref counts at 1 instead of 0 for speed
    
            * WebKitSupport/FrameLoaderClientWx.cpp:
            (WebCore::FrameLoaderClientWx::createDocumentLoader): Use create function
            instead of new.
    
    LayoutTests:
    
    2008-06-14  Darin Adler  <darin@apple.com>
    
            Reviewed by Maciej.
    
            - test for https://bugs.webkit.org/show_bug.cgi?id=19538
              <rdar://problem/5957595> Reading transition property from the style JS gives the wrong value
    
            * fast/dom/CSSStyleDeclaration/resources/transition-property-names.js: Added.
            * fast/dom/CSSStyleDeclaration/transition-property-names-expected.txt: Added.
            * fast/dom/CSSStyleDeclaration/transition-property-names.html: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d5ceaf86
WebCore.base.exp 41.5 KB