Skip to content
  • commit-queue@webkit.org's avatar
    [BlackBerry] PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate · d54ab84d
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=90817
    
    Patch by Yong Li <yoli@rim.com> on 2012-07-09
    Reviewed by Rob Buis.
    
    PR# 174085.
    PagePopupBlackBerry::closePopup() should always clear the pointer in WebPagePrivate to avoid crashes.
    This patch also removes unused variable m_parentPopup and its setter.
    
    * Api/WebPage.cpp:
    (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Remove m_parentPopup.
    * Api/WebPage_p.h:
    (WebPagePrivate):
    * WebCoreSupport/ChromeClientBlackBerry.cpp:
    (WebCore::ChromeClientBlackBerry::closePagePopup):
    * WebCoreSupport/PagePopupBlackBerry.cpp:
    (WebCore::PagePopupBlackBerry::init): Remove the setParentPopup() call.
    (WebCore::PagePopupBlackBerry::closePopup): Clear the reference in WebPagePrivate.
    * WebCoreSupport/SelectPopupClient.cpp:
    (WebCore::SelectPopupClient::setValueAndClosePopup): Add an assert for valid m_element.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d54ab84d