Skip to content
  • rniwa@webkit.org's avatar
    REGRESSION(r105396): drag state is not cleared after each drag · d22c03e2
    rniwa@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=76878
    
    Reviewed by Alexey Proskuryakov.
    
    Source/WebCore: 
    
    Revert a part of r105396 that made performDragAndDrop not call clearDragState
    when the default action was not prevented since it caused a regression.
    
    I'm pretty certain always calling clearDragState in performDragAndDrop is wrong
    but I can't think of a test case where this becomes a problem at the moment.
    Since this area is not well tested, revert the change instead of making further
    changes to the code base.
    
    Tests: fast/events/clear-drag-state.html
           fast/events/clear-edit-drag-state.html
    
    * page/EventHandler.cpp:
    (WebCore::EventHandler::performDragAndDrop):
    
    LayoutTests: 
    
    Add a regression test to ensure we don't fire extra dragenter event
    on the second drag at an element that contains the dragged content.
    
    * fast/events/clear-drag-state-expected.txt: Added.
    * fast/events/clear-drag-state.html: Added.
    * fast/events/clear-edit-drag-state-expected.txt: Added.
    * fast/events/clear-edit-drag-state.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    d22c03e2