Skip to content
  • zalan@apple.com's avatar
    REGRESSION (r155607): Javascript site does not load visually on panerabread.com · d07b231f
    zalan@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=122461
    
    Reviewed by Simon Fraser.
    
    Do not modify the composited layer backing's internal layer structure directly
    when the clipping behaviour changes.
    
    When we directly create/destroy RenderLayerBacking::m_ancestorClippingLayer to
    reflect the new clipping state, other, depending layers need updating. In order to
    not to corrupt the internal hierarchy, mark the compositing layers dirty and let
    the normal updating mechanism take care of creating/destroying the ancestor layers.
    
    Source/WebCore:
    
    Existing tests are extended.
    
    * rendering/RenderLayer.cpp:
    (WebCore::RenderLayer::checkIfDescendantClippingContextNeedsUpdate):
    (WebCore::RenderLayer::styleChanged):
    * rendering/RenderLayer.h:
    * rendering/RenderLayerBacking.h:
    
    LayoutTests:
    
    * compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
    * compositing/overflow/clipping-behaviour-change-is-not-propagated...
    d07b231f