• benjamin@webkit.org's avatar
    [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac · cc507c8c
    benjamin@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=111297
    
    Reviewed by Kenneth Rohde Christiansen.
    
    Source/WebCore: 
    
    The 'view-mode' Media Feature spec is implemented in WebCore but
    there is no WebKit support for it on Mac.
    Because of this, we always lie and report a windowed view mode.
    
    This patch add a feature flag for the feature and disable it on
    Mac so that we stop reporting incorrect default values.
    
    * WebCore.exp.in:
    * css/CSSValueKeywords.in:
    * css/MediaFeatureNames.h:
    (MediaFeatureNames):
    * css/MediaQueryEvaluator.cpp:
    * css/MediaQueryExp.cpp:
    (WebCore::featureWithCSSValueID):
    (WebCore::featureWithoutValue):
    * page/Page.cpp:
    (WebCore::Page::Page):
    * page/Page.h:
    (Page):
    
    Source/WebKit2: 
    
    * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
    * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
    * WebProcess/WebPage/WebPage.cpp:
    * WebProcess/WebPage/WebPage.h:
    
    Source/WTF: 
    
    * wtf/FeatureDefines.h: Add a new feature flag for the view-mode
    CSS media: ENABLE_VIEW_MODE_CSS_MEDIA.
    
    Tools: 
    
    * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
    (WTR::TestRunner::setViewModeMediaFeature):
    
    LayoutTests: 
    
    * platform/mac/TestExpectations:
    Mark the view-mode tests as failing to track any regression
    or crash in this area.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    cc507c8c
SetupWebKitFeatures.m4 5.73 KB