Skip to content
  • jpu@apple.com's avatar
    2011-05-11 Jia Pu <jpu@apple.com> · ca72090a
    jpu@apple.com authored
            Reviewed by Darin Adler.
    
            CorrectionPanel sometimes hangs in dismissSoon().
            https://bugs.webkit.org/show_bug.cgi?id=60599
            <rdar://problem/9313628>
    
            Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
            to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
            for condition checking.
    
            * WebCoreSupport/CorrectionPanel.h:
            * WebCoreSupport/CorrectionPanel.mm:
            (CorrectionPanel::CorrectionPanel):
            (CorrectionPanel::show):
            (CorrectionPanel::dismissSoon):
            (CorrectionPanel::dismissInternal):
            (CorrectionPanel::handleAcceptedReplacement):
    2011-05-11  Jia Pu  <jpu@apple.com>
    
            Reviewed by Darin Adler.
    
            CorrectionPanel sometimes hangs in dismissSoon().
            https://bugs.webkit.org/show_bug.cgi?id=60599
            <rdar://problem/9313628>
    
            Make sure dismissSoon() won't wait indefinitely if handleAcceptedReplacement() sets m_resultForSynchronousDismissal
            to nil. Added a designated variable m_isDismissing, instead of piggy-backing m_resultForSynchronousDismissal,
            for condition checking.
    
            * UIProcess/mac/CorrectionPanel.h:
            * UIProcess/mac/CorrectionPanel.mm:
            (WebKit::CorrectionPanel::CorrectionPanel):
            (WebKit::CorrectionPanel::show):
            (WebKit::CorrectionPanel::dismissSoon):
            (WebKit::CorrectionPanel::dismissInternal):
            (WebKit::CorrectionPanel::handleAcceptedReplacement):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ca72090a