Skip to content
  • dcheng@chromium.org's avatar
    Having a drop handler prevents navigation on drop even if event is not cancelled · c5ad721b
    dcheng@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=79172
    
    Reviewed by Ryosuke Niwa.
    
    Source/WebCore:
    
    Only early return if the drop handler prevents the default action.
    http://trac.webkit.org/changeset/105396 introduced this issue when fixing some other aspects
    of DnD handling.
    
    Test: fast/events/drop-handler-should-not-stop-navigate.html
    
    * page/DragController.cpp:
    (WebCore::DragController::performDrag):
    (WebCore::DragController::concludeEditDrag): Remove the assert. By definition, we want to
        allow default actions to run now if they weren't explicitly canceled.
    
    LayoutTests:
    
    * fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
    * fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
    * fast/events/drop-handler-should-not-stop-navigate.html: Added.
    * http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler
        to prevent bubbled events from causing navigation.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c5ad721b