• timothy@apple.com's avatar
    Fixes: Bug 19679: iframes with a height of 32,768px or greater do not layout correctly · c59ad194
    timothy@apple.com authored
    WebCore:
    
    2008-06-19  Timothy Hatcher  <timothy@apple.com>
    
            Changed all lineHeight, baselinePosition and verticalPositionHint
            calls to return int instead of short. The short was overflowing
            when a value greater than 32,767 was encountered.
    
            Fixes: iframes with a height of 32,768px or greater do not layout correctly
            https://bugs.webkit.org/show_bug.cgi?id=19679
    
            Reviewed by Dave Hyatt.
    
            Test: fast/css/line-height-overflow.html
    
            * rendering/RenderBR.cpp:
            (WebCore::RenderBR::baselinePosition):
            * rendering/RenderBR.h:
            * rendering/RenderBlock.cpp:
            (WebCore::RenderBlock::lineHeight):
            * rendering/RenderBlock.h:
            * rendering/RenderFlow.cpp:
            * rendering/RenderFlow.h:
            * rendering/RenderListBox.cpp:
            * rendering/RenderListBox.h:
            * rendering/RenderListMarker.cpp:
            (WebCore::RenderListMarker::lineHeight):
            * rendering/RenderListMarker.h:
            * rendering/RenderObject.cpp:
            (WebCore::RenderObject::verticalPositionHint):
            * rendering/RenderObject.h:
            (WebCore::):
            * rendering/RenderPath.cpp:
            (WebCore::RenderPath::lineHeight):
            * rendering/RenderPath.h:
            * rendering/RenderReplaced.cpp:
            (WebCore::RenderReplaced::lineHeight):
            * rendering/RenderReplaced.h:
            * rendering/RenderSVGContainer.cpp:
            (WebCore::RenderSVGContainer::lineHeight):
            * rendering/RenderSVGContainer.h:
            * rendering/RenderSVGHiddenContainer.cpp:
            (WebCore::RenderSVGHiddenContainer::lineHeight):
            * rendering/RenderSVGHiddenContainer.h:
            * rendering/RenderSVGRoot.cpp:
            (WebCore::RenderSVGRoot::lineHeight):
            * rendering/RenderSVGRoot.h:
            * rendering/RenderSlider.cpp:
            * rendering/RenderSlider.h:
            * rendering/RenderTableCell.cpp:
            * rendering/RenderTableCell.h:
            * rendering/RenderTableCol.h:
            * rendering/RenderTableRow.h:
            * rendering/RenderTableSection.h:
            * rendering/RenderText.cpp:
            * rendering/RenderText.h:
            * rendering/RenderTextControl.cpp:
            * rendering/RenderTextControl.h:
            * rendering/RenderTheme.cpp:
            * rendering/RenderTheme.h:
            * rendering/RenderThemeMac.h:
            * rendering/RenderThemeMac.mm:
            * rendering/RenderThemeSafari.cpp:
            * rendering/RenderThemeSafari.h:
    
    LayoutTests:
    
    2008-06-19  Timothy Hatcher  <timothy@apple.com>
    
            Test for: iframes with a height of 32,768px or greater do not layout correctly
            https://bugs.webkit.org/show_bug.cgi?id=19679
    
            Reviewed by Dave Hyatt.
    
            * fast/css/line-height-overflow.html: Added.
            * platform/mac/fast/css/line-height-overflow-expected.txt: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c59ad194
RenderBlock.cpp 180 KB