Skip to content
  • commit-queue@webkit.org's avatar
    AX: Cancel button in search field not accessible. · c55bc639
    commit-queue@webkit.org authored
    <https://webkit.org/b/120322>
    
    Source/WebCore:
    
    Expose the cancel button that shows in an input element of
    type search to accessibility.
    
    Patch by Sam White <samuel_white@apple.com> on 2013-08-28
    Reviewed by Chris Fleizach.
    
    Test: platform/mac/accessibility/search-field-cancel-button.html
    
    * CMakeLists.txt:
    * English.lproj/Localizable.strings:
    * GNUmakefile.list.am:
    * Target.pri:
    * WebCore.vcxproj/WebCore.vcxproj:
    * WebCore.xcodeproj/project.pbxproj:
    * accessibility/AXObjectCache.cpp:
    (WebCore::createFromRenderer):
    * accessibility/AccessibilityAllInOne.cpp:
    * accessibility/AccessibilitySearchFieldButtons.cpp: Added.
    (WebCore::AccessibilitySearchFieldCancelButton::create):
    (WebCore::AccessibilitySearchFieldCancelButton::AccessibilitySearchFieldCancelButton):
    (WebCore::AccessibilitySearchFieldCancelButton::accessibilityDescription):
    (WebCore::AccessibilitySearchFieldCancelButton::accessibilityText):
    (WebCore::AccessibilitySearchFieldCancelButton::press):
    (WebCore::AccessibilitySearchFieldCancelButton::computeAccessibilityIsIgnored):
    * accessibility/AccessibilitySearchFieldButtons.h: Added.
    * dom/Element.h:
    (WebCore::Element::isSearchFieldCancelButtonElement):
    * html/shadow/TextControlInnerElements.h:
    * platform/LocalizedStrings.cpp:
    (WebCore::AXSearchFieldCancelButtonText):
    * platform/LocalizedStrings.h:
    * platform/efl/LocalizedStringsEfl.cpp:
    (WebCore::AXSearchFieldCancelButtonText):
    * platform/gtk/LocalizedStringsGtk.cpp:
    (WebCore::AXSearchFieldCancelButtonText):
    * platform/qt/LocalizedStringsQt.cpp:
    (WebCore::AXSearchFieldCancelButtonText):
    
    LayoutTests:
    
    Make sure the cancel button that shows in an input element of
    type search is accessible and actionable.
    
    Patch by Sam White <samuel_white@apple.com> on 2013-08-28
    Reviewed by Chris Fleizach.
    
    * platform/mac/accessibility/search-field-cancel-button-expected.txt: Added.
    * platform/mac/accessibility/search-field-cancel-button.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c55bc639