• abarth@webkit.org's avatar
    Remove support for target-densitydpi in the viewport meta tag · c27d725c
    abarth@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=88047
    
    Reviewed by Kenneth Rohde Christiansen.
    
    Source/WebCore:
    
    The target-densitydpi parameter was originally implemented on Android,
    but it does not appear to be widely used and introduces significant
    implementation complexity because it forces us to track three scale
    factors (defaultDeviceScaleFactor, deviceScaleFactor, and
    pageScaleFactor) rather than just two (deviceScaleFactor and
    pageScaleFactor).
    
    There don't appear to be many web sites that use target-densitydpi
    because it is not supported on iOS.  There are also concerns from the
    standards community about the design of the feature.  It seems our best
    course of action is to remove target-densitydpi and address these use
    cases via other mechanisms, such as responsive images and device units
    in CSS because those approaches are likely to be implemented broadly.
    
    * dom/ViewportArguments.cpp:
    (WebCore::computeViewportAttributes):
    (WebCore):
    (WebCore::setViewportFeature):
    (WebCore::viewportErrorMessageTemplate):
    (WebCore::viewportErrorMessageLevel):
    * dom/ViewportArguments.h:
    (WebCore::ViewportArguments::ViewportArguments):
    (ViewportArguments):
    (WebCore::ViewportArguments::operator==):
    
    Source/WebKit/blackberry:
    
    * Api/WebPage.cpp:
    (BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
    * Api/WebViewportArguments.cpp:
    (BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
    (BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
    * Api/WebViewportArguments.h:
    
    Source/WebKit/efl:
    
    * ewk/ewk_view.cpp:
    (_ewk_view_priv_new):
    
    LayoutTests:
    
    These tests are no longer needed because they're testing a feature we
    no longer support.
    
    * fast/viewport/viewport-133-expected.txt: Removed.
    * fast/viewport/viewport-133.html: Removed.
    * fast/viewport/viewport-92-expected.txt: Removed.
    * fast/viewport/viewport-92.html: Removed.
    * fast/viewport/viewport-93-expected.txt: Removed.
    * fast/viewport/viewport-93.html: Removed.
    * fast/viewport/viewport-94-expected.txt: Removed.
    * fast/viewport/viewport-94.html: Removed.
    * fast/viewport/viewport-95-expected.txt: Removed.
    * fast/viewport/viewport-95.html: Removed.
    * fast/viewport/viewport-96-expected.txt: Removed.
    * fast/viewport/viewport-96.html: Removed.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c27d725c
ChangeLog 211 KB