Skip to content
  • timothy@apple.com's avatar
    Change how threading exceptions are checked so they are reported by what round they were added. · c129e3fd
    timothy@apple.com authored
    WebCore:
    
    2009-03-20  Timothy Hatcher  <timothy@apple.com>
    
            Change how threading exceptions are checked so they are reported
            by what round they were added. That way WebKit can decided the
            behavior per-round based on linked-on-or-after checks.
    
            <rdar://problem/6626741&6648478&6635474&6674079>
    
            Reviewed by Darin Adler.
    
            * WebCore.base.exp: Export the new symbols.
            * bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
            * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
            * platform/ThreadCheck.h:
            * platform/mac/ThreadCheck.mm:
            (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read.
            (WebCore::setDefaultThreadViolationBehavior): Take a round argument.
            (WebCore::reportThreadViolation): Ditto.
            (WebCoreReportThreadViolation): Ditto.
    
    WebKit:
    
    2009-03-20  Timothy Hatcher  <timothy@apple.com>
    
            Change how threading exceptions are checked so they are reported
            by what round they were added. That way WebKit can decided the
            behavior per-round based on linked-on-or-after checks.
    
            <rdar://problem/6626741&6648478&6635474&6674079>
    
            Reviewed by Darin Adler.
    
            * History/WebBackForwardList.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
            * History/WebHistoryItem.mm: Ditto.
            * Misc/WebIconDatabase.mm: Ditto.
    
            * WebView/WebArchive.mm: Use the new WebCoreThreadViolationCheckRoundTwo macro.
            * WebView/WebResource.mm: Ditto.
            (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Check Mail's bundle version
            to truly decide if it is an old Mail client.
            * WebView/WebView.mm: Ditto.
    
            * Misc/WebKitVersionChecks.h: Add a new linked-on-or-after version define.
            * WebView/WebFrameView.mm:
            (-[WebFrameView initWithFrame:]): Set the default thread violation behavior per-round
            based on difference version checks and the Mail workaround check.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    c129e3fd