Skip to content
  • commit-queue@webkit.org's avatar
    REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime · bfadee5c
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=20599
    
    Add a "Download Video"/"Download Audio" context menu item to download media
    elements.
    
    Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
    Reviewed by Beth Dakin.
    
    Source/WebCore:
    
    No new tests. media/context-menu-action.html,
    which has been disabled by bug 116651, is used to test context menus.
    
    * English.lproj/Localizable.strings: Updated to
    include localizable strings for "Download Video" and "Download Audio".
    
    * page/ContextMenuController.cpp: Updated to
    include and handle a "Download Video/Audio" context menu item.
    
    * platform/ContextMenuItem.h:
    
    * platform/LocalizedStrings.cpp:
    * platform/LocalizedStrings.h:
    * platform/efl/LocalizedStringsEfl.cpp:
    * platform/gtk/LocalizedStringsGtk.cpp:
    * platform/qt/LocalizedStringsQt.cpp:
    Updated to include localizable strings for "Download Video" and "Download Audio".
    
    Source/WebKit/efl:
    
    * WebCoreSupport/AssertMatchingEnums.cpp:
    * ewk/ewk_contextmenu.h:
    Updated to include new EWK enum type for "Download Video/Audio" context menu item.
    
    Source/WebKit2:
    
    * Shared/API/c/WKContextMenuItemTypes.h: Updated to include
    an enum type for the "Download Video/Audio" context menu item.
    
    * Shared/API/c/WKSharedAPICast.h: Updated to associate
    the enums in WebKit and WebCore that handle the "Download Video/Audio"
    context menu item.
    
    * UIProcess/API/efl/ewk_context_menu.cpp:
    * UIProcess/API/efl/ewk_context_menu_item.cpp:
    * UIProcess/API/efl/ewk_context_menu_item.h:
    Updated to include new EWK enum type for "Download Video/Audio" context menu item.
    
    * UIProcess/WebPageProxy.cpp: Updated to
    handle the "Download Video/Audio" context menu item mouse click
    and download the media item in the UI process.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bfadee5c