Skip to content
  • fsamuel@chromium.org's avatar
    Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated... · bc05e3b7
    fsamuel@chromium.org authored
    Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
    https://bugs.webkit.org/show_bug.cgi?id=69009
    
    Reviewed by Simon Fraser.
    
    .:
    
    * Source/autotools/symbols.filter:
    
    Source/WebCore:
    
    Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
    Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
    absoluteBoundingBoxRectIgnoringTransforms() partially addreses // FIXME: useTransforms should go away eventually.
    
    * WebCore.exp.in:
    * dom/Element.cpp:
    (WebCore::Element::screenRect):
    * dom/Node.cpp:
    (WebCore::Node::getRect):
    (WebCore::Node::renderRect):
    * html/shadow/SliderThumbElement.cpp:
    (WebCore::SliderThumbElement::setPositionFromPoint):
    * html/shadow/TextControlInnerElements.cpp:
    (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
    * inspector/DOMNodeHighlighter.cpp:
    * plugins/IFrameShimSupport.cpp:
    (WebCore::getPluginOcclusions):
    * rendering/RenderBlock.cpp:
    (WebCore::RenderBlock::absoluteRects):
    (WebCore::RenderBlock::absoluteQuads):
    * rendering/RenderBlock.h:
    * rendering/RenderBox.cpp:
    (WebCore::RenderBox::absoluteRects):
    (WebCore::RenderBox::absoluteQuads):
    * rendering/RenderBox.h:
    * rendering/RenderFileUploadControl.cpp:
    (WebCore::RenderFileUploadControl::paintObject):
    * rendering/RenderIFrame.cpp:
    (WebCore::RenderIFrame::flattenFrame):
    * rendering/RenderInline.cpp:
    (WebCore::RenderInline::absoluteRects):
    (WebCore::RenderInline::culledInlineAbsoluteRects):
    (WebCore::RenderInline::absoluteQuads):
    (WebCore::RenderInline::culledInlineAbsoluteQuads):
    * rendering/RenderInline.h:
    * rendering/RenderMenuList.cpp:
    (WebCore::RenderMenuList::showPopup):
    * rendering/RenderObject.cpp:
    (WebCore::RenderObject::absoluteBoundingBoxRect):
    (WebCore::RenderObject::addAbsoluteRectForLayer):
    (WebCore::RenderObject::paintingRootRect):
    * rendering/RenderObject.h:
    (WebCore::RenderObject::absoluteRects):
    (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
    (WebCore::RenderObject::absoluteQuads):
    * rendering/RenderText.cpp:
    (WebCore::RenderText::absoluteRects):
    (WebCore::RenderText::absoluteQuads):
    * rendering/RenderText.h:
    * rendering/RenderTextControlSingleLine.cpp:
    (WebCore::RenderTextControlSingleLine::showPopup):
    * rendering/RenderThemeSafari.cpp:
    (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
    (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
    (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
    * rendering/RenderView.cpp:
    (WebCore::RenderView::absoluteRects):
    (WebCore::RenderView::absoluteQuads):
    * rendering/RenderView.h:
    * rendering/svg/RenderSVGBlock.cpp:
    (WebCore::RenderSVGBlock::absoluteRects):
    * rendering/svg/RenderSVGBlock.h:
    * rendering/svg/RenderSVGHiddenContainer.cpp:
    (WebCore::RenderSVGHiddenContainer::absoluteQuads):
    * rendering/svg/RenderSVGHiddenContainer.h:
    * rendering/svg/RenderSVGInline.cpp:
    (WebCore::RenderSVGInline::absoluteQuads):
    * rendering/svg/RenderSVGInline.h:
    * rendering/svg/RenderSVGModelObject.cpp:
    (WebCore::RenderSVGModelObject::absoluteRects):
    (WebCore::RenderSVGModelObject::absoluteQuads):
    * rendering/svg/RenderSVGModelObject.h:
    * rendering/svg/RenderSVGText.cpp:
    (WebCore::RenderSVGText::absoluteQuads):
    * rendering/svg/RenderSVGText.h:
    * testing/Internals.cpp:
    (WebCore::Internals::boundingBox):
    
    Source/WebKit/qt:
    
    * Api/qwebframe.cpp:
    (QWebHitTestResultPrivate::QWebHitTestResultPrivate):
    
    Source/WebKit2:
    
    * win/WebKit2.def:
    * win/WebKit2CFLite.def:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bc05e3b7