Skip to content
  • tonikitoo@webkit.org's avatar
    Make QWebPagePrivate's (QWidget) view to be a QWeakPointer. · bb3a8652
    tonikitoo@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=30779
    
    Patch by Antonio Gomes <tonikitoo@webkit.org> on 2009-10-27
    Reviewed by Antti Koivisto and Holger Freyther.
    
    The fact that it was been set from external objects of qwebpage
    and not being deleted internally can lead to dangling references.
    
    * Api/qgraphicswebview.cpp:
    (QGraphicsWebView::~QGraphicsWebView):
    * Api/qwebpage.cpp:
    (QWebPagePrivate::QWebPagePrivate):
    (QWebPagePrivate::createContextMenu):
    (QWebPagePrivate::handleSoftwareInputPanel):
    (QWebPagePrivate::keyPressEvent):
    (QWebPage::setView):
    (QWebPage::view):
    (QWebPage::javaScriptAlert):
    (QWebPage::javaScriptConfirm):
    (QWebPage::javaScriptPrompt):
    (QWebPage::shouldInterruptJavaScript):
    (QWebPage::createWindow):
    (QWebPage::extension):
    (QWebPage::chooseFile):
    (QWebPage::userAgentForUrl):
    * Api/qwebpage_p.h:
    * Api/qwebview.cpp:
    (QWebView::~QWebView):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    bb3a8652